fix: config loading on subdomains waits for updated config #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
the activate event is fired when the service worker is first activated, and then the channel.onmessagefrom event listener is set up. by the time the channel receives any messages, the event passed to activate will be done, and waitUntil has no effect (and throws an error)
SgtPooki
commented
Mar 8, 2024
Comment on lines
+74
to
+75
| debugLib.enable(config.debug ?? '') // set debug level first. | ||
| log('config-debug: setting config %O for domain %s', config, window.location.origin) |
Member
Author
There was a problem hiding this comment.
set debug level before calling log method so debug level is taken into consideration immediately.
SgtPooki
commented
Mar 8, 2024
| await setConfig(config) | ||
| // TODO: use channel.messageAndWaitForResponse to ensure that the config is loaded before proceeding. | ||
| channel.postMessage({ target: 'SW', action: 'RELOAD_CONFIG' }) | ||
| // TODO: show spinner / disable buttons while waiting for response |
Member
Author
There was a problem hiding this comment.
things happen pretty fast so i don't think we want a spinner or other things, but maybe?
SgtPooki
commented
Mar 8, 2024
Member
Author
SgtPooki
left a comment
SgtPooki
left a comment
There was a problem hiding this comment.
self review of some more minor improvements and manual config update verification
6 tasks
SgtPooki
added a commit
that referenced
this pull request
Mar 9, 2024
* refactor: remove unused helia andu se verified fetch * chore: remove empty line * fix: load config iframe using a hash fragment fixes #88 * fix: load default config initially * chore: fix linting errors * chore: remove unused deps * chore: re-add needed @helia/ipns dependency * fix: set verifiedFetch when sw is activated * chore: remove lib/heliaFetch and cleanup sw.ts (#95) * fix: config loading on subdomains waits for updated config (#94) * fix: config loading on subdomains waits for updated config * fix: remove event.waitUtil inside channel.onmessagefrom the activate event is fired when the service worker is first activated, and then the channel.onmessagefrom event listener is set up. by the time the channel receives any messages, the event passed to activate will be done, and waitUntil has no effect (and throws an error) * fix: service worker handles being disposed of * fix: preload request from redirect page is handled by sw * chore: better trace logging for config updates --------- Co-authored-by: Daniel N <[email protected]> Co-authored-by: Russell Dempsey <[email protected]>
Member
|
Great stuff! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
fix: config loading on subdomains waits for updated config
Description
Minor updates to #89
Addresses the issue brought up in #89:
Notes & open questions
Demo
2024-03-07.at.18.17.23.-.Plum.Anglerfish.mp4
Change checklist