-
Notifications
You must be signed in to change notification settings - Fork 21
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
Right now, every subdomain load makes additional request to the root domain with custom query parameter, which is effectively bypassing caches (even one from https://github.com/ipshipyard/waterworks-infra/pull/42) and forces rainbow to do work every time again.
This is why we sometimes see /config?origin being stuck in pending state:
And then often resulting in 504 for the iframe:
Solution
We should lean towards maximizing HTTP and browser cache and switch config logic from server-side /path?query to client-side #framents
- iframe should make request to
/#configof the root domain, not/config. This way already cached/response can be returned instead of bypassing caches and rainbow having to produce it again ?originquery param should be replaced with frament param, e.g./#config@origin=.?originwill create separate cache entry per origin./#foois always better, works without SW being in place, URL hash fragments are not sent to HTTP server, allowing for cache reuse, but can still be read by JS running in iframe
SgtPooki
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working

