fix: reduce bundle size #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
jacobheun
requested changes
Jan 11, 2019
There was a problem hiding this comment.
@hugomrdias I ran this against the js-ipfs core test suite npm run test:node:core and there are failing tests. There may just need to be some tests updated there (for example I think some are checking the constructor name for numbers looking for 'Big', which is now BigNumber in repo tests), but we should make sure everything here is working properly before updating tests there.
jacobheun
reviewed
Jan 11, 2019
hugomrdias
force-pushed
the
fix/bundle-size
branch
from
73185b2 to
ca42d55
Compare
jacobheun
requested changes
Mar 15, 2019
jacobheun
approved these changes
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR doesn't actually reduces repo bundle size but help a lot the top level repo like js-ipfs