fix: update attempt to add helia to identify agent version (#268)

The identify service does not pull the agent string from the peer
store any more so attempt to update it on the service directly.

Author: achingbrain

packages/helia/src/index.ts

@@ -143,16 +143,7 @@ export async function createHelia (init: HeliaInit = {}): Promise<Helia<unknown>
   }
 
   // add helia to agent version
-  if (helia.libp2p.isStarted()) {
-    await addHeliaToAgentVersion(helia)
-  } else {
-    helia.libp2p.addEventListener('start', () => {
-      addHeliaToAgentVersion(helia)
-        .catch(err => {
-          log.error('could not add Helia to agent version', err)
-        })
-    })
-  }
+  addHeliaToAgentVersion(helia)
 
   return helia
 }
@@ -169,34 +160,18 @@ function isLibp2p (obj: any): obj is Libp2p {
   return funcs.every(m => typeof obj[m] === 'function')
 }
 
-async function addHeliaToAgentVersion (helia: Helia): Promise<void> {
+function addHeliaToAgentVersion (helia: Helia<any>): void {
   // add helia to agent version
-  const peer = await helia.libp2p.peerStore.get(helia.libp2p.peerId)
-  const versionBuf = peer.metadata.get('AgentVersion')
-
-  if (versionBuf == null) {
-    // identify was not configured
-    return
-  }
-
-  let versionStr = new TextDecoder().decode(versionBuf)
+  try {
+    const existingAgentVersion = helia.libp2p.services.identify.host.agentVersion
 
-  if (versionStr.match(/js-libp2p\/\d+\.\d+\.\d+\sUserAgent=/) == null) {
-    // the user changed the agent version
-    return
-  }
+    if (existingAgentVersion.match(/js-libp2p\/\d+\.\d+\.\d+\sUserAgent=/) == null) {
+      // the user changed the agent version
+      return
+    }
 
-  if (versionStr.includes(name)) {
-    // update version name
-    versionStr = `${name}/${version} ${versionStr.split(' ').slice(1).join(' ')}`
-  } else {
-    // just prepend version name
-    versionStr = `${name}/${version} ${versionStr}`
+    helia.libp2p.services.identify.host.agentVersion = `${name}/${version} ${helia.libp2p.services.identify.host.agentVersion}`
+  } catch (err) {
+    log.error('could not add Helia to agent version', err)
   }
-
-  await helia.libp2p.peerStore.merge(helia.libp2p.peerId, {
-    metadata: {
-      AgentVersion: new TextEncoder().encode(versionStr)
-    }
-  })
 }

packages/helia/test/factory.spec.ts

@@ -42,11 +42,8 @@ describe('helia factory', () => {
   it('adds helia details to the AgentVersion', async () => {
     helia = await createHelia()
 
-    const peer = await helia.libp2p.peerStore.get(helia.libp2p.peerId)
-    const agentVersionBuf = peer.metadata.get('AgentVersion')
-    const agentVersion = new TextDecoder().decode(agentVersionBuf)
-
-    expect(agentVersion).to.include('helia/')
+    expect(helia).to.have.nested.property('libp2p.services.identify.host.agentVersion')
+      .that.includes('helia/')
   })
 
   it('does not add helia details to the AgentVersion when it has been overridden', async () => {
@@ -56,18 +53,15 @@ describe('helia factory', () => {
           webSockets()
         ],
         services: {
-          identity: identifyService({
+          identify: identifyService({
             agentVersion: 'my custom agent version'
           })
         }
       })
     })
 
-    const peer = await helia.libp2p.peerStore.get(helia.libp2p.peerId)
-    const agentVersionBuf = peer.metadata.get('AgentVersion')
-    const agentVersion = new TextDecoder().decode(agentVersionBuf)
-
-    expect(agentVersion).to.not.include('helia/')
+    expect(helia).to.have.nested.property('libp2p.services.identify.host.agentVersion')
+      .that.does.not.include('helia/')
   })
 
   it('does not add helia details to the AgentVersion when identify is not configured', async () => {