Integrating Configurable max-in-memory-size for webclient (#36)

* Adding Customization over response size.

* optimizing webclient builder.

---------

Co-authored-by: mmishra8 <[email protected]>

Author: mkm1997

pom.xml

@@ -3,7 +3,7 @@
 
     <groupId>com.intuit.rwebpulse</groupId>
     <artifactId>rwebpulse</artifactId>
-    <version>1.0.1</version>
+    <version>1.0.2</version>
     <packaging>jar</packaging>
     <name>Spring Web Client</name>
     <url>https://github.com/intuit/rwebpulse</url>

src/main/java/com/intuit/springwebclient/config/SpringWebClientConfig.java

@@ -10,4 +10,5 @@
 public class SpringWebClientConfig {
     private HttpConnectionPoolConfig connectionPool;
     private HttpClientConfig httpClientConfig;
+    private int maxInMemorySize;
 }

src/main/java/com/intuit/springwebclient/config/WebClientConfiguration.java

@@ -9,6 +9,7 @@
 import org.springframework.context.annotation.Configuration;
 
 import org.springframework.http.client.reactive.ReactorClientHttpConnector;
+import org.springframework.web.reactive.function.client.ExchangeStrategies;
 import org.springframework.web.reactive.function.client.WebClient;
 import reactor.netty.http.client.HttpClient;
 import reactor.netty.resources.ConnectionProvider;
@@ -24,6 +25,7 @@ public class WebClientConfiguration {
     private final SpringWebClientConfig webClientConfiguration;
     private final WebClientRequestFilter webClientRequestFilter;
 
+
     @Bean
     public ConnectionProvider webClientConnectionProvider(){
         return ConnectionProvider.builder(WebClientConstants.CONNECTION_PROVIDER_NAME)
@@ -42,10 +44,20 @@ public HttpClient webHttpClient(){
     }
 
     @Bean("RWebPulseClient")
-    public WebClient createWebClient(){
-        return WebClient.builder()
-                .clientConnector(new ReactorClientHttpConnector(webHttpClient()))
-                .filter(webClientRequestFilter.getFilter())
-                .build();
+    public WebClient createWebClient() {
+
+        WebClient.Builder builder = WebClient.builder();
+        builder.clientConnector(new ReactorClientHttpConnector(webHttpClient()))
+                .filter(webClientRequestFilter.getFilter());
+        //if max-in-memory-size is not set in config then the building client with default size else creating client with custom max-in-memory-size
+        if (webClientConfiguration.getMaxInMemorySize() > 0) {
+            builder.exchangeStrategies(
+                            ExchangeStrategies.builder()
+                                    .codecs(configurer -> configurer
+                                            .defaultCodecs()
+                                            .maxInMemorySize(webClientConfiguration.getMaxInMemorySize()))
+                                    .build());
+        }
+        return builder.build();
     }
 }

src/test/java/com/intuit/springwebclient/config/WebClientConfigurationTest.java

@@ -21,6 +21,7 @@ public class WebClientConfigurationTest {
     @Mock
     private WebClientRequestFilter webClientRequestFilter;
 
+
     @InjectMocks
     private WebClientConfiguration webClientConfiguration;
 
@@ -44,6 +45,38 @@ public void testWebClientConnectionProvider() {
 
         Mockito.when(springWebClientConfig.getHttpClientConfig()).thenReturn(httpClientConfig);
 
+        Mockito.when(springWebClientConfig.getMaxInMemorySize()).thenReturn(100);
+
+        Mockito.when(webClientRequestFilter.getFilter()).thenReturn(new ExchangeFilterFunction() {
+            @Override
+            public Mono<ClientResponse> filter(ClientRequest request, ExchangeFunction next) {
+                return null;
+            }
+        });
+
+        WebClient webClient = webClientConfiguration.createWebClient();
+
+    }
+
+    @Test
+    public void testWebClientConnectionProvider_withoutMaxSize() {
+        HttpConnectionPoolConfig poolConfig = new HttpConnectionPoolConfig();
+        poolConfig.setMaxConnections(200);
+        poolConfig.setMaxIdleTime(2000L);
+        poolConfig.setMaxLifeTime(3500L);
+        poolConfig.setPendingAcquireTimeout(1500L);
+
+        Mockito.when(springWebClientConfig.getConnectionPool()).thenReturn(poolConfig);
+
+        ConnectionProvider connectionProvider = webClientConfiguration.webClientConnectionProvider();
+        Assertions.assertEquals(200, connectionProvider.maxConnections());
+
+        HttpClientConfig httpClientConfig = new HttpClientConfig();
+        httpClientConfig.setConnectTimeoutMillis(5000);
+        httpClientConfig.setConnectTimeoutMillis(3000);
+
+
+        Mockito.when(springWebClientConfig.getHttpClientConfig()).thenReturn(httpClientConfig);
         Mockito.when(webClientRequestFilter.getFilter()).thenReturn(new ExchangeFilterFunction() {
             @Override
             public Mono<ClientResponse> filter(ClientRequest request, ExchangeFunction next) {