@@ -91,7 +91,7 @@ However, the flow is not ideal for many reasons:
9191backend. We could slightly improve this issue by using a library call to the
9292SPIR-V translator instead of the tool, however the library API requires setting
9393up an object to represent the arguments while we only have strings, and it's
94- non-trivial to parse the trings to figure out how to create the argument
94+ non-trivial to parse the strings to figure out how to create the argument
9595object. Since we plan to use the SPIR-V backend in the long term, this does not
9696seem to be worth the effort.
9797
@@ -104,9 +104,9 @@ when we actually are going to run codegen.
104104fully linked module to accurately compute metadata, see the above explanation
105105of SYCL requirement 2). We could get around storing the module by computing the
106106metadata inside the LTO framework and storing it for late use by the SYCL
107- bundling code, but doing this would require SYCL-only customizations including
107+ bundling code, but doing this would require even more SYCL-only customizations including
108108even more new function arguments and modifications of the ` OffloadFile ` class.
109- It's also complicated because the LTO framework is multithreaded, and not all
109+ There are also compliations because the LTO framework is multithreaded, and not all
110110LLVM data structures are thread safe.
111111
112112The proposed long-term SYCL ThinLTO flow is as follows:
@@ -117,7 +117,7 @@ The biggest difference here is that we are running codegen using the SPIR-V
117117backend.
118118
119119Also, instead of using a lambda function in the ` PreCodeGenModuleHook `
120- callback, we can take advantage of the ` PreCodeGenPassesHook ` field to add
120+ callback to run SYCL finalization passes , we can take advantage of the ` PreCodeGenPassesHook ` field to add
121121passes to the pass manager that the LTO framework will run.
122122
123123It is possible that the number of device images in the fat executable
0 commit comments