Commit f5b683a
committed
mm-use-stack_depot-for-recording-kmemleaks-backtrace-checkpatch-fixes
WARNING: please, no spaces at the start of a line
torvalds#59: FILE: mm/kmemleak.c:362:
+ for (i = 0; i < nr_entries; i++) {$
WARNING: suspect code indent for conditional statements (7, 15)
torvalds#59: FILE: mm/kmemleak.c:362:
+ for (i = 0; i < nr_entries; i++) {
+ void *ptr = (void *)entries[i];
ERROR: code indent should use tabs where possible
torvalds#60: FILE: mm/kmemleak.c:363:
+ void *ptr = (void *)entries[i];$
WARNING: please, no spaces at the start of a line
torvalds#60: FILE: mm/kmemleak.c:363:
+ void *ptr = (void *)entries[i];$
ERROR: code indent should use tabs where possible
torvalds#61: FILE: mm/kmemleak.c:364:
+ warn_or_seq_printf(seq, " [<%p>] %pS\n", ptr, ptr);$
WARNING: Missing a blank line after declarations
torvalds#61: FILE: mm/kmemleak.c:364:
+ void *ptr = (void *)entries[i];
+ warn_or_seq_printf(seq, " [<%p>] %pS\n", ptr, ptr);
WARNING: please, no spaces at the start of a line
torvalds#61: FILE: mm/kmemleak.c:364:
+ warn_or_seq_printf(seq, " [<%p>] %pS\n", ptr, ptr);$
WARNING: please, no spaces at the start of a line
torvalds#62: FILE: mm/kmemleak.c:365:
+ }$
ERROR: space required before the open parenthesis '('
torvalds#71: FILE: mm/kmemleak.c:384:
+ if(object->trace_handle)
total: 3 errors, 6 warnings, 107 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
NOTE: Whitespace errors detected.
You may wish to use scripts/cleanpatch or scripts/cleanfile
./patches/mm-use-stack_depot-for-recording-kmemleaks-backtrace.patch has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Please run checkpatch prior to sending patches
Cc: Catalin Marinas <[email protected]>
Cc: ke.wang <[email protected]>
Cc: Matthew Wilcox (Oracle) <[email protected]>
Cc: Vlastimil Babka <[email protected]>
Cc: Zhaoyang Huang <[email protected]>
Cc: Zhaoyang Huang <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>1 parent c18b253 commit f5b683a
1 file changed
+5
-5
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
359 | 359 | | |
360 | 360 | | |
361 | 361 | | |
362 | | - | |
363 | | - | |
364 | | - | |
365 | | - | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
366 | 366 | | |
367 | 367 | | |
368 | 368 | | |
| |||
381 | 381 | | |
382 | 382 | | |
383 | 383 | | |
384 | | - | |
| 384 | + | |
385 | 385 | | |
386 | 386 | | |
387 | 387 | | |
| |||
0 commit comments