Merge branch 'pci/controller/xgene-msi'

bjorn-helgaas · bjorn-helgaas · commit 1bffb51aafb5 · 2025-09-12T17:11:41.000-05:00
- Fix typo that returned EINVAL (not -EINVAL) for failure in
  xgene_msi_handler_setup() (Dan Carpenter)

* pci/controller/xgene-msi:
  PCI: xgene-msi: Return negative -EINVAL in xgene_msi_handler_setup()
diff --git a/drivers/pci/controller/pci-xgene-msi.c b/drivers/pci/controller/pci-xgene-msi.c
@@ -311,7 +311,7 @@ static int xgene_msi_handler_setup(struct platform_device *pdev)
 		msi_val = xgene_msi_int_read(xgene_msi, i);
 		if (msi_val) {
 			dev_err(&pdev->dev, "Failed to clear spurious IRQ\n");
-			return EINVAL;
+			return -EINVAL;
 		}
 
 		irq = platform_get_irq(pdev, i);

Original file line number	Diff line number	Diff line change
`@@ -311,7 +311,7 @@ static int xgene_msi_handler_setup(struct platform_device *pdev)`
`311`	`311`	`msi_val = xgene_msi_int_read(xgene_msi, i);`
`312`	`312`	`if (msi_val) {`
`313`	`313`	`dev_err(&pdev->dev, "Failed to clear spurious IRQ\n");`
`314`		`- return EINVAL;`
	`314`	`+ return -EINVAL;`
`315`	`315`	`}`
`316`	`316`
`317`	`317`	`irq = platform_get_irq(pdev, i);`