adapted #1
Open
adapted #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Diemand <[email protected]>
avieth
suggested changes
Sep 8, 2019
Contributor
avieth
left a comment
avieth
left a comment
There was a problem hiding this comment.
Maintainer and author updates OK of course but I'm against the use of "observables" in the synopsis. I assume you're referring to notion of Control.Tracer.Observable.Obsercable, from the old incarnation in iohk-monitoring-framework? If so, I'd argue that's out of the scope of this package. It deals with a particular kind of thing that might be traced, rather than tracing in general.
Signed-off-by: Alexander Diemand <[email protected]>
Contributor
Author
|
agree, the observables should go into a |
coot
requested changes
Jun 20, 2021
Contributor
coot
left a comment
coot
left a comment
There was a problem hiding this comment.
Could you squash the commits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Diemand [email protected]