From 324b06421be3868a45073efc905781eb87d3a3a5 Mon Sep 17 00:00:00 2001 From: Vladimir Smirnov Date: Mon, 25 Jul 2022 08:25:16 +0200 Subject: [PATCH] bulk_query: remove unused variable waitFinished was never actually used (initialized and then assigned from within a goroutine, but value was never checked). Not catching that was a bug in Golang that was fixed in 1.18 See: https://golang.org/issue/8560 --- bulk_query/query.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/bulk_query/query.go b/bulk_query/query.go index 8f800608..1ddfe3ab 100644 --- a/bulk_query/query.go +++ b/bulk_query/query.go @@ -428,10 +428,8 @@ loop: // channel when done: log.Println("Waiting for workers to finish") waitCh := make(chan int) - waitFinished := false go func() { workersGroup.Wait() - waitFinished = true waitCh <- 1 }() waitTimer := time.NewTimer(time.Minute * 10)