From 1f4f4620fb3b50087f174b7cfc6863fc6b0b8af5 Mon Sep 17 00:00:00 2001 From: pierrepetersmeier <155652256+pierrepetersmeier@users.noreply.github.com> Date: Wed, 24 Jan 2024 20:46:59 +0100 Subject: [PATCH 1/5] - Delete JavaDoc link in line 19. - Updated AUTHORS file(Developer and Copyright 2024). - link to AUTHORS at line 70. --- AUTHORS | 11 ++++++++++- CONTRIBUTING.md | 7 ++----- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/AUTHORS b/AUTHORS index 4c5ffecc5..5f4594090 100644 --- a/AUTHORS +++ b/AUTHORS @@ -1,10 +1,14 @@ -Copyright (c) 2023, Institute of Energy Systems, Energy Efficiency and Energy Economics (ie3) +Copyright (c) 2024, Institute of Energy Systems, Energy Efficiency and Energy Economics (ie3) All rights reserved. Lead Developers: - Johannes Hiry - Chris Kittl - Debopama Sen-Sarma + - Thomas Oberließen + - Daniel Feismann + - Johannes Bao + - Sebastian Peter Main Contributers: - Johannes Hiry - https://github.com/johanneshiry @@ -20,3 +24,8 @@ Main Contributers: - Marius Staudt - https://github.com/staudtMarius - Lara Roumeliotis - https://github.com/lararou - Vicky Bung - https://github.com/vickybung1 + - Daniel Feismann - https://github.com/danielfeismann + - Johannes Bao - https://github.com/SimonHuette + - Julian Hohmann - https://github.com/jo-bao + - Simon Huette - https://github.com/julianhohmann + - Pierre Petersmeier - http://github.com/pierrepetersmeier diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 613c30be6..02981e3ca 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -16,7 +16,7 @@ With this document we would like to give you some orientation on how you can con ## Testing and reporting bugs We really appreciate your usage of this project. Whenever you find a bug, it would be nice to check, if this isn't a feature to us. :wink: -You may find extensive information about the intended behaviour when you [Read the Docs](https://powersystemdatamodel.readthedocs.io/en/latest/) or within the [javadoc](https://ie3-institute.github.io/PowerSystemDataModel/javadoc/). +You may find extensive information about the intended behaviour when you [Read the Docs](https://powersystemdatamodel.readthedocs.io/en/latest/). If you still think it's a bug, please raise an [issue](https://guides.github.com/features/issues/) for us. Considering the following aspects in your inquiry, assists us in helping you: @@ -67,9 +67,6 @@ Before marking the pull request as 'ready to review', take these precautionary a `gradle finalizePR` summarizes all of these steps . ## For any doubts -... please contact -* Johannes (@johanneshiry), -* Debopama (@sensarmad) or -* Chris (@ckittl) +... please contact [us](AUTHORS) We are happy to help! :smiley: From 04d11e14c73e73c25b0eed498efc0f96c69412e0 Mon Sep 17 00:00:00 2001 From: pierrepetersmeier <155652256+pierrepetersmeier@users.noreply.github.com> Date: Wed, 24 Jan 2024 20:57:24 +0100 Subject: [PATCH 2/5] -correct GitHub links --- AUTHORS | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/AUTHORS b/AUTHORS index 5f4594090..4c0b256d1 100644 --- a/AUTHORS +++ b/AUTHORS @@ -25,7 +25,7 @@ Main Contributers: - Lara Roumeliotis - https://github.com/lararou - Vicky Bung - https://github.com/vickybung1 - Daniel Feismann - https://github.com/danielfeismann - - Johannes Bao - https://github.com/SimonHuette - - Julian Hohmann - https://github.com/jo-bao - - Simon Huette - https://github.com/julianhohmann + - Johannes Bao - https://github.com/jo-bao + - Julian Hohmann - https://github.com/julianhohmann + - Simon Huette - https://github.com/SimonHuette - Pierre Petersmeier - http://github.com/pierrepetersmeier From 9e49c1f0197e678e7a84b9d4df1fc02058df1f4c Mon Sep 17 00:00:00 2001 From: pierrepetersmeier <155652256+pierrepetersmeier@users.noreply.github.com> Date: Wed, 24 Jan 2024 21:08:08 +0100 Subject: [PATCH 3/5] - Deleted JavaDoc sentence in line 54. --- CONTRIBUTING.md | 1 - 1 file changed, 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 02981e3ca..e30f1618a 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -51,7 +51,6 @@ In order to maintain a consistent project, we thought of some general design gui * We :heart: **immutability**. Therefore, please don't provide setters and use proper instantiation instead. * `double a = b * pow(x, j)`? :hand: Please **be expressive** in what you code! -* Document your code with **javadoc**. ### Testing Ensure the proper function of your code by [test driven development (TDD)](https://www.guru99.com/test-driven-development.html). From 2c90dd8b6e7633f8611c976a4875f6899afd8589 Mon Sep 17 00:00:00 2001 From: pierrepetersmeier <155652256+pierrepetersmeier@users.noreply.github.com> Date: Thu, 25 Jan 2024 11:01:32 +0100 Subject: [PATCH 4/5] - Added JavaDoc sentence in line 54. - changelog.md entrie. --- CHANGELOG.md | 2 ++ CONTRIBUTING.md | 1 + 2 files changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 16b2b6086..c8d100af1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -24,6 +24,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Allowing for additional unused columns in sources [#839](https://github.com/ie3-institute/PowerSystemDataModel/issues/839) - Improving column name validation to only run once per source [#849](https://github.com/ie3-institute/PowerSystemDataModel/issues/849) - Refactored and abstracted `EntitySource`s and `EntityData` creation [#969](https://github.com/ie3-institute/PowerSystemDataModel/issues/969) +- Updated contributing.md [#737](https://github.com/ie3-institute/PowerSystemDataModel/issues/737) + ## [4.1.0] - 2023-11-02 diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index e30f1618a..02981e3ca 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -51,6 +51,7 @@ In order to maintain a consistent project, we thought of some general design gui * We :heart: **immutability**. Therefore, please don't provide setters and use proper instantiation instead. * `double a = b * pow(x, j)`? :hand: Please **be expressive** in what you code! +* Document your code with **javadoc**. ### Testing Ensure the proper function of your code by [test driven development (TDD)](https://www.guru99.com/test-driven-development.html). From ba2fa585ee283a2ddfcfe12bd59c6f324aca97f3 Mon Sep 17 00:00:00 2001 From: pierrepetersmeier <155652256+pierrepetersmeier@users.noreply.github.com> Date: Thu, 25 Jan 2024 11:09:05 +0100 Subject: [PATCH 5/5] -delete space --- CHANGELOG.md | 1 - 1 file changed, 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c8d100af1..769dc95aa 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -26,7 +26,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Refactored and abstracted `EntitySource`s and `EntityData` creation [#969](https://github.com/ie3-institute/PowerSystemDataModel/issues/969) - Updated contributing.md [#737](https://github.com/ie3-institute/PowerSystemDataModel/issues/737) - ## [4.1.0] - 2023-11-02 ### Fixed