Skip to content

Conversation

@johanneshiry
Copy link
Member

Resolves #388

@johanneshiry johanneshiry added the enhancement New feature or request label Jun 22, 2021
@johanneshiry johanneshiry added this to the Version 2.1 milestone Jun 22, 2021
@johanneshiry johanneshiry requested review from baszach and ckittl June 22, 2021 07:48
@johanneshiry
Copy link
Member Author

!test

@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #389 (2b8ca4e) into dev (c58ef33) will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #389      +/-   ##
============================================
+ Coverage     78.56%   78.68%   +0.11%     
- Complexity     2046     2073      +27     
============================================
  Files           254      255       +1     
  Lines          8124     8160      +36     
  Branches        767      767              
============================================
+ Hits           6383     6421      +38     
+ Misses         1353     1352       -1     
+ Partials        388      387       -1     
Impacted Files Coverage Δ
...datamodel/io/source/csv/CsvResultEntitySource.java 76.47% <0.00%> (ø)
...factory/result/SystemParticipantResultFactory.java 93.93% <0.00%> (+1.51%) ⬆️
...edu/ie3/datamodel/io/source/csv/CsvDataSource.java 94.31% <0.00%> (+4.08%) ⬆️
.../models/result/system/SystemParticipantResult.java 45.83% <0.00%> (+4.16%) ⬆️
.../edu/ie3/datamodel/models/result/ResultEntity.java 50.00% <0.00%> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5735868...2b8ca4e. Read the comment docs.

@baszach
Copy link
Contributor

baszach commented Jun 29, 2021

@johanneshiry do you think we can approve and merge this PR? Please, take a look at the test I wrote (CsvResultEntitySourceTest) and tell me if it needs changing/additions.

@baszach baszach merged commit d925833 into dev Jun 30, 2021
@sebastian-peter sebastian-peter deleted the jh/#388-result-entity-source branch July 30, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for ResultEntity Source

3 participants