Skip to content

Commit 9f8cdb4

Browse files
committed
address reviewers comments
1 parent 18a1853 commit 9f8cdb4

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

src/main/java/edu/ie3/datamodel/models/input/system/EvcsInput.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,8 @@ public boolean equals(Object o) {
184184
return chargingPoints == evcsInput.chargingPoints
185185
&& Double.compare(evcsInput.cosPhiRated, cosPhiRated) == 0
186186
&& type.equals(evcsInput.type)
187-
&& locationType.equals(evcsInput.locationType);
187+
&& locationType.equals(evcsInput.locationType)
188+
&& v2gSupport == evcsInput.v2gSupport;
188189
}
189190

190191
@Override

src/test/groovy/edu/ie3/datamodel/io/factory/input/participant/EvcsInputFactoryTest.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ class EvcsInputFactoryTest extends Specification implements FactoryTestHelper {
8080
assert chargingPoints == Integer.parseInt(parameter["chargingpoints"])
8181
assert cosPhiRated == Double.parseDouble(parameter["cosphirated"])
8282
assert locationType == EvcsLocationType.CHARGING_HUB_TOWN
83-
assert v2gSupport == false
83+
assert !v2gSupport
8484
}
8585
}
8686

src/test/groovy/edu/ie3/datamodel/models/input/system/EvcsInputTest.groovy

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ class EvcsInputTest extends Specification {
2121
.type(ChargingPointTypeUtils.TeslaSuperChargerV3)
2222
.cosPhiRated(0.7d).chargingPoints(1)
2323
.locationType(EvcsLocationType.CHARGING_HUB_HIGHWAY)
24+
.v2gSupport(true)
2425
.build()
2526

2627
then:
@@ -34,6 +35,7 @@ class EvcsInputTest extends Specification {
3435
assert cosPhiRated == 0.7d
3536
assert chargingPoints == 1
3637
assert locationType == EvcsLocationType.CHARGING_HUB_HIGHWAY
38+
assert v2gSupport
3739
}
3840
}
3941
}

0 commit comments

Comments
 (0)