Skip to content

Conversation

erfanium
Copy link
Collaborator

typeof o === "object" doesn't always return expected result (e.g: with array, null, regexp, ....).

@coveralls
Copy link

coveralls commented Apr 16, 2020

Coverage Status

Coverage increased (+0.001%) to 99.744% when pulling 70cb6bb on erfanium:master into 3a2378f on icebob:master.

@erfanium erfanium requested a review from icebob April 16, 2020 20:32
@erfanium
Copy link
Collaborator Author

@icebob
I think this code is better

Copy link
Owner

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, but I feel a little lack when the source has an empty object {} property, in this case, the pointer will be copied instead of copy the object. But I hope it won't cause a problem.

@icebob icebob merged commit b538cd9 into icebob:master Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants