Skip to content

Commit 663e11e

Browse files
committed
Fix ByHash json parsing
Signed-off-by: Simon Dudley <[email protected]>
1 parent 650e70c commit 663e11e

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/engine/EngineGetPayloadBodiesByHashV1.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import org.hyperledger.besu.ethereum.chain.Blockchain;
2828

2929
import java.util.Arrays;
30+
import java.util.List;
3031
import java.util.stream.Collectors;
3132

3233
import io.vertx.core.Vertx;
@@ -55,14 +56,17 @@ public String getName() {
5556
public JsonRpcResponse syncResponse(final JsonRpcRequestContext request) {
5657
engineCallListener.executionEngineCalled();
5758

58-
final Hash[] blockHashes = request.getRequiredParameter(0, Hash[].class);
59+
final List<Hash> blockHashes =
60+
Arrays.stream(request.getRequest().getParams())
61+
.map(Hash.class::cast)
62+
.collect(Collectors.toList());
5963

6064
traceLambda(LOG, "{} parameters: blockHashes {}", () -> getName(), () -> blockHashes);
6165

6266
final Blockchain blockchain = protocolContext.getBlockchain();
6367
return new JsonRpcSuccessResponse(
6468
request.getRequest().getId(),
6569
blockResultFactory.payloadBodiesCompleteV1(
66-
Arrays.stream(blockHashes).map(blockchain::getBlockBody).collect(Collectors.toList())));
70+
blockHashes.stream().map(blockchain::getBlockBody).collect(Collectors.toList())));
6771
}
6872
}

ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/engine/EngineGetPayloadBodiesByHashV1Test.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -224,9 +224,7 @@ private JsonRpcResponse resp(final Hash[] hashes) {
224224
return method.response(
225225
new JsonRpcRequestContext(
226226
new JsonRpcRequest(
227-
"2.0",
228-
RpcMethod.ENGINE_GET_PAYLOAD_BODIES_BY_HASH_V1.getMethodName(),
229-
new Object[] {hashes})));
227+
"2.0", RpcMethod.ENGINE_GET_PAYLOAD_BODIES_BY_HASH_V1.getMethodName(), hashes)));
230228
}
231229

232230
private EngineGetPayloadBodiesResultV1 fromSuccessResp(final JsonRpcResponse resp) {

0 commit comments

Comments
 (0)