Skip to content

Conversation

@nateraw
Copy link
Contributor

@nateraw nateraw commented Oct 17, 2022

Frame filename right now is frame_{frame_idx}.png, which leads to frames like frame_1.png, frame_10.png, etc. This is an issue if you end up wanting to ffmpeg them together later.

This pr updates to do frame_{frame_idx:06d}.png so frame filenames will be friendlier with glob patterns, keeping files sorted: frame_000001.png, frame_000010.png, etc.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 17, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@patrickvonplaten patrickvonplaten merged commit 627ad6e into main Oct 17, 2022
@patrickvonplaten patrickvonplaten deleted the interpolate-example-frame-filename branch October 17, 2022 18:09
kumquatexpress pushed a commit to harvestlabs/diffusers that referenced this pull request Oct 19, 2022
prathikr pushed a commit to prathikr/diffusers that referenced this pull request Oct 26, 2022
PhaneeshB pushed a commit to nod-ai/diffusers that referenced this pull request Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants