Fix training push_to_hub (unconditional image generation): models were not saved before pushing to hub #868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
patrickvonplaten
approved these changes
Oct 17, 2022
Contributor
patrickvonplaten
left a comment
patrickvonplaten
left a comment
There was a problem hiding this comment.
Yes this makes sense to me! We should always save the pipeline in the local output dir no matter if we push to the Hub or not.
anton-l
approved these changes
Oct 17, 2022
Member
anton-l
left a comment
anton-l
left a comment
There was a problem hiding this comment.
My oversight, thanks for fixing!
kumquatexpress
pushed a commit
to harvestlabs/diffusers
that referenced
this pull request
Oct 19, 2022
…e not saved before pushing to hub (huggingface#868) Fix: models were not saved before pushing to hub.
prathikr
pushed a commit
to prathikr/diffusers
that referenced
this pull request
Oct 26, 2022
…e not saved before pushing to hub (huggingface#868) Fix: models were not saved before pushing to hub.
PhaneeshB
pushed a commit
to nod-ai/diffusers
that referenced
this pull request
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resulted in repos with no model files such as: https://huggingface.co/pcuenq/ddpm-ema-faces-64-50/tree/main