Skip to content

Bump to 0.6.0.dev0 #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Oct 14, 2022
Merged

Bump to 0.6.0.dev0 #831

merged 15 commits into from
Oct 14, 2022

Conversation

@anton-l
Copy link
Member

@anton-l anton-l commented Oct 13, 2022

No description provided.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 13, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

anton-l
anton-l commented Oct 13, 2022
View reviewed changes
src/diffusers/schedulers/scheduling_ddim.py
Comment on lines -124 to -130
deprecate(
"tensor_format",
"0.6.0",
"If you're running your code in PyTorch, you can safely remove this argument.",
take_from=kwargs,
)

Copy link
Member Author

@anton-l anton-l Oct 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing these deprecations now, as they're fairly harmless.

Copy link
Contributor

@patrickvonplaten patrickvonplaten Oct 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

**kwargs has to be removed as well as it's now left unchecked and it was added only for backwards breaking comp which we're breaking now

anton-l
anton-l commented Oct 13, 2022
View reviewed changes
src/diffusers/utils/outputs.py
Comment on lines 85 to -91
def __getitem__(self, k):
if isinstance(k, str):
inner_dict = {k: v for (k, v) in self.items()}
if self.__class__.__name__ in ["StableDiffusionPipelineOutput", "ImagePipelineOutput"] and k == "sample":
deprecate("samples", "0.6.0", "Please use `.images` or `'images'` instead.")
return inner_dict["images"]
Copy link
Member Author

@anton-l anton-l Oct 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels safe to deprecate this now

Copy link
Contributor

@patrickvonplaten patrickvonplaten Oct 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree!

anton-l
anton-l commented Oct 13, 2022
View reviewed changes
src/diffusers/schedulers/scheduling_utils.py
Comment on lines -44 to -52

def set_format(self, tensor_format="pt"):
deprecate(
"set_format",
"0.6.0",
"If you're running your code in PyTorch, you can safely remove this function as the schedulers are always"
" in Pytorch",
)
return self
Copy link
Member Author

@anton-l anton-l Oct 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think we have any custom schedulers out there, so fairly safe to remove

@patrickvonplaten
Copy link
Contributor

patrickvonplaten commented Oct 13, 2022

Might have some merge conflicts here: #833

@anton-l
Copy link
Member Author

anton-l commented Oct 13, 2022

Resolved 👍

patrickvonplaten
patrickvonplaten reviewed Oct 14, 2022
View reviewed changes
patrickvonplaten
patrickvonplaten reviewed Oct 14, 2022
View reviewed changes
patrickvonplaten
patrickvonplaten reviewed Oct 14, 2022
View reviewed changes
patrickvonplaten
patrickvonplaten reviewed Oct 14, 2022
View reviewed changes
patrickvonplaten
patrickvonplaten reviewed Oct 14, 2022
View reviewed changes
patrickvonplaten
patrickvonplaten reviewed Oct 14, 2022
View reviewed changes
patrickvonplaten
patrickvonplaten reviewed Oct 14, 2022
View reviewed changes
patrickvonplaten
patrickvonplaten approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for making the changes. We can and should remove the **kwargs arg from init now IMO.

@anton-l anton-l merged commit 52394b5 into main Oct 14, 2022
@anton-l anton-l deleted the bump-0-6-0-dev branch October 14, 2022 11:43
kumquatexpress pushed a commit to harvestlabs/diffusers that referenced this pull request Oct 19, 2022
@anton-l @patrickvonplaten @kumquatexpress
Bump to 0.6.0.dev0 (huggingface#831)
b59419c 
* Bump to 0.6.0.dev0

* Deprecate tensor_format and .samples

* style

* upd

* upd

* style

* sample -> images

* Update src/diffusers/schedulers/scheduling_ddpm.py

Co-authored-by: Patrick von Platen <[email protected]>

* Update src/diffusers/schedulers/scheduling_ddim.py

Co-authored-by: Patrick von Platen <[email protected]>

* Update src/diffusers/schedulers/scheduling_karras_ve.py

Co-authored-by: Patrick von Platen <[email protected]>

* Update src/diffusers/schedulers/scheduling_lms_discrete.py

Co-authored-by: Patrick von Platen <[email protected]>

* Update src/diffusers/schedulers/scheduling_pndm.py

Co-authored-by: Patrick von Platen <[email protected]>

* Update src/diffusers/schedulers/scheduling_sde_ve.py

Co-authored-by: Patrick von Platen <[email protected]>

* Update src/diffusers/schedulers/scheduling_sde_vp.py

Co-authored-by: Patrick von Platen <[email protected]>

Co-authored-by: Patrick von Platen <[email protected]>
prathikr pushed a commit to prathikr/diffusers that referenced this pull request Oct 26, 2022
@anton-l @patrickvonplaten
Bump to 0.6.0.dev0 (huggingface#831)
61a4fdb 
* Bump to 0.6.0.dev0

* Deprecate tensor_format and .samples

* style

* upd

* upd

* style

* sample -> images

* Update src/diffusers/schedulers/scheduling_ddpm.py

Co-authored-by: Patrick von Platen <[email protected]>

* Update src/diffusers/schedulers/scheduling_ddim.py

Co-authored-by: Patrick von Platen <[email protected]>

* Update src/diffusers/schedulers/scheduling_karras_ve.py

Co-authored-by: Patrick von Platen <[email protected]>

* Update src/diffusers/schedulers/scheduling_lms_discrete.py

Co-authored-by: Patrick von Platen <[email protected]>

* Update src/diffusers/schedulers/scheduling_pndm.py

Co-authored-by: Patrick von Platen <[email protected]>

* Update src/diffusers/schedulers/scheduling_sde_ve.py

Co-authored-by: Patrick von Platen <[email protected]>

* Update src/diffusers/schedulers/scheduling_sde_vp.py

Co-authored-by: Patrick von Platen <[email protected]>

Co-authored-by: Patrick von Platen <[email protected]>
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
@anton-l @patrickvonplaten
Bump to 0.6.0.dev0 (huggingface#831)
409b0ac 
* Bump to 0.6.0.dev0

* Deprecate tensor_format and .samples

* style

* upd

* upd

* style

* sample -> images

* Update src/diffusers/schedulers/scheduling_ddpm.py

Co-authored-by: Patrick von Platen <[email protected]>

* Update src/diffusers/schedulers/scheduling_ddim.py

Co-authored-by: Patrick von Platen <[email protected]>

* Update src/diffusers/schedulers/scheduling_karras_ve.py

Co-authored-by: Patrick von Platen <[email protected]>

* Update src/diffusers/schedulers/scheduling_lms_discrete.py

Co-authored-by: Patrick von Platen <[email protected]>

* Update src/diffusers/schedulers/scheduling_pndm.py

Co-authored-by: Patrick von Platen <[email protected]>

* Update src/diffusers/schedulers/scheduling_sde_ve.py

Co-authored-by: Patrick von Platen <[email protected]>

* Update src/diffusers/schedulers/scheduling_sde_vp.py

Co-authored-by: Patrick von Platen <[email protected]>

Co-authored-by: Patrick von Platen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patil-suraj patil-suraj Awaiting requested review from patil-suraj

1 more reviewer

@patrickvonplaten patrickvonplaten patrickvonplaten approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@anton-l @HuggingFaceDocBuilderDev @patrickvonplaten