Skip to content

Commit 306688a

Browse files
committed
Merge branch 'fix_make_validate_it' into 'IT-1.11.2'
fix make validate failure cherry-pick from upstream opencontainers#1243 Issues info: Issue ID: 6 Title: runc执行make validate失败 Issue url: docker-archive#6 See merge request docker/runc!23
2 parents 9c6fabf + e333701 commit 306688a

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

libcontainer/integration/exec_test.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ func testExecPS(t *testing.T, userns bool) {
3838
defer remove(rootfs)
3939
config := newTemplateConfig(rootfs)
4040
if userns {
41-
config.UidMappings = []configs.IDMap{{0, 0, 1000}}
42-
config.GidMappings = []configs.IDMap{{0, 0, 1000}}
41+
config.UidMappings = []configs.IDMap{{HostID: 0, ContainerID: 0, Size: 1000}}
42+
config.GidMappings = []configs.IDMap{{HostID: 0, ContainerID: 0, Size: 1000}}
4343
config.Namespaces = append(config.Namespaces, configs.Namespace{Type: configs.NEWUSER})
4444
}
4545

@@ -180,8 +180,8 @@ func testRlimit(t *testing.T, userns bool) {
180180

181181
config := newTemplateConfig(rootfs)
182182
if userns {
183-
config.UidMappings = []configs.IDMap{{0, 0, 1000}}
184-
config.GidMappings = []configs.IDMap{{0, 0, 1000}}
183+
config.UidMappings = []configs.IDMap{{HostID: 0, ContainerID: 0, Size: 1000}}
184+
config.GidMappings = []configs.IDMap{{HostID: 0, ContainerID: 0, Size: 1000}}
185185
config.Namespaces = append(config.Namespaces, configs.Namespace{Type: configs.NEWUSER})
186186
}
187187

@@ -1531,8 +1531,8 @@ func TestInitJoinNetworkAndUser(t *testing.T) {
15311531

15321532
// Execute a long-running container
15331533
config1 := newTemplateConfig(rootfs)
1534-
config1.UidMappings = []configs.IDMap{{0, 0, 1000}}
1535-
config1.GidMappings = []configs.IDMap{{0, 0, 1000}}
1534+
config1.UidMappings = []configs.IDMap{{HostID: 0, ContainerID: 0, Size: 1000}}
1535+
config1.GidMappings = []configs.IDMap{{HostID: 0, ContainerID: 0, Size: 1000}}
15361536
config1.Namespaces = append(config1.Namespaces, configs.Namespace{Type: configs.NEWUSER})
15371537
container1, err := newContainer(config1)
15381538
ok(t, err)
@@ -1563,8 +1563,8 @@ func TestInitJoinNetworkAndUser(t *testing.T) {
15631563
defer remove(rootfs2)
15641564

15651565
config2 := newTemplateConfig(rootfs2)
1566-
config2.UidMappings = []configs.IDMap{{0, 0, 1000}}
1567-
config2.GidMappings = []configs.IDMap{{0, 0, 1000}}
1566+
config2.UidMappings = []configs.IDMap{{HostID: 0, ContainerID: 0, Size: 1000}}
1567+
config2.GidMappings = []configs.IDMap{{HostID: 0, ContainerID: 0, Size: 1000}}
15681568
config2.Namespaces.Add(configs.NEWNET, netns1)
15691569
config2.Namespaces.Add(configs.NEWUSER, userns1)
15701570
config2.Cgroups.Path = "integration/test2"

libcontainer/integration/execin_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,8 @@ func testExecInRlimit(t *testing.T, userns bool) {
8989

9090
config := newTemplateConfig(rootfs)
9191
if userns {
92-
config.UidMappings = []configs.IDMap{{0, 0, 1000}}
93-
config.GidMappings = []configs.IDMap{{0, 0, 1000}}
92+
config.UidMappings = []configs.IDMap{{HostID: 0, ContainerID: 0, Size: 1000}}
93+
config.GidMappings = []configs.IDMap{{HostID: 0, ContainerID: 0, Size: 1000}}
9494
config.Namespaces = append(config.Namespaces, configs.Namespace{Type: configs.NEWUSER})
9595
}
9696

@@ -503,8 +503,8 @@ func TestExecInUserns(t *testing.T) {
503503
ok(t, err)
504504
defer remove(rootfs)
505505
config := newTemplateConfig(rootfs)
506-
config.UidMappings = []configs.IDMap{{0, 0, 1000}}
507-
config.GidMappings = []configs.IDMap{{0, 0, 1000}}
506+
config.UidMappings = []configs.IDMap{{HostID: 0, ContainerID: 0, Size: 1000}}
507+
config.GidMappings = []configs.IDMap{{HostID: 0, ContainerID: 0, Size: 1000}}
508508
config.Namespaces = append(config.Namespaces, configs.Namespace{Type: configs.NEWUSER})
509509
container, err := newContainer(config)
510510
ok(t, err)

0 commit comments

Comments
 (0)