From b38d581055e01fc2b4ead7504cebb4047adad84c Mon Sep 17 00:00:00 2001 From: Eric Badiere Date: Mon, 11 Nov 2024 09:38:37 -0700 Subject: [PATCH 1/2] chore: Upgrade node version to 20. Signed-off-by: Eric Badiere --- .github/workflows/conformity-workflow.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/conformity-workflow.yml b/.github/workflows/conformity-workflow.yml index 8d91d51c71..33f79075b9 100644 --- a/.github/workflows/conformity-workflow.yml +++ b/.github/workflows/conformity-workflow.yml @@ -27,10 +27,10 @@ jobs: repository: 'ethereum/execution-apis' path: 'execution-apis' - - name: Use Node.js TLS 18 + - name: Use Node.js TLS 20 uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2 with: - node-version: 18 + node-version: 20 - name: Install dependencies run: npm install @@ -59,10 +59,10 @@ jobs: - name: Checkout repository uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6 - - name: Use Node.js TLS 18 + - name: Use Node.js TLS 20 uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2 with: - node-version: 18 + node-version: 20 - name: Install make run: sudo apt-get update; sudo apt-get install build-essential -y From 3939165a09d7d71a04b478e93aa0ce847be21f3c Mon Sep 17 00:00:00 2001 From: Eric Badiere Date: Mon, 11 Nov 2024 10:07:49 -0700 Subject: [PATCH 2/2] chore: Updated references to node 20. Signed-off-by: Eric Badiere --- .github/workflows/dapp.yml | 2 -- .github/workflows/test.yml | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/dapp.yml b/.github/workflows/dapp.yml index ed988075c9..fca7a7115d 100644 --- a/.github/workflows/dapp.yml +++ b/.github/workflows/dapp.yml @@ -34,8 +34,6 @@ jobs: uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2 with: node-version: 20 - #cache: "npm" Disabling this as it causes the workflow to hang, trying to retrieve the cache. Not removing it, because it could be retuned in the future. - #cache-dependency-path: "**/package-lock.json" - name: Install build tools run: sudo apt-get update && sudo apt-get install -y make gcc g++ diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index ea593998b5..2cb251debf 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -24,7 +24,7 @@ jobs: - name: Install build tools run: sudo apt-get update && sudo apt-get install -y make gcc g++ - - name: Use Node.js TLS 18 + - name: Use Node.js TLS 20 uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2 with: node-version: 20