Skip to content

Commit fcd41c2

Browse files
authored
revert test skip introduced for #239 (#244)
1 parent ae0bd2b commit fcd41c2

File tree

3 files changed

+3
-21
lines changed

3 files changed

+3
-21
lines changed

.github/workflows/ci-pandas-pre.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99
python-version: ["3.10", "3.11", "3.12"]
1010
numpy: ["numpy>=1.20.3,<2.0.0", "numpy==2.0.0.rc2"]
1111
pandas: ["pandas>=3.0.0"]
12-
pint: ["pint==0.24"]
12+
pint: ["pint>=0.24"]
1313

1414
runs-on: ubuntu-latest
1515

pint_pandas/testsuite/test_issues.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ def test_reductions(self, reduction):
138138
t = self._timeit(getattr(s, reduction)).to("ms")
139139

140140
if t > 0:
141-
assert tp <= 5 * t
141+
assert tp <= 10 * t
142142

143143

144144
def test_issue_86():

pint_pandas/testsuite/test_pandas_extensiontests.py

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -38,14 +38,7 @@ def dtype():
3838

3939

4040
_base_numeric_dtypes = [float, int]
41-
if pandas_version_info <= (3, 0, 0):
42-
_all_numeric_dtypes = _base_numeric_dtypes + [np.complex128]
43-
else:
44-
# work around to make test pass in the context of GH #239
45-
# complex induce NumpyExtensionArray that are not managed by
46-
# latest version of pandas.core.algorithms.take
47-
# https://github.com/pandas-dev/pandas/issues/59177
48-
_all_numeric_dtypes = _base_numeric_dtypes
41+
_all_numeric_dtypes = _base_numeric_dtypes + [np.complex128]
4942

5043

5144
@pytest.fixture(params=_all_numeric_dtypes)
@@ -321,17 +314,6 @@ def test_insert_invalid(self):
321314
def _get_expected_exception(
322315
self, op_name: str, obj, other
323316
): # -> type[Exception] | None, but Union types not understood by Python 3.9
324-
if op_name in [
325-
"__radd__",
326-
"__rsub__",
327-
"__rmul__",
328-
"__rtruediv__",
329-
"__rpow__",
330-
] and pandas_version_info >= (3, 0, 0):
331-
pytest.skip(
332-
f"ongoing issue with pandas >=3 with {type(obj).__name__} that does not support {op_name}. GH #239"
333-
)
334-
return TypeError
335317
if op_name in ["__pow__", "__rpow__"]:
336318
return DimensionalityError
337319

0 commit comments

Comments
 (0)