Skip to content

Conversation

@thiagodebastos
Copy link

@thiagodebastos thiagodebastos commented Apr 6, 2022

This cleans up some unused code, removing a warning that comes up during build of helix source:

helix-term/src/ui/picker.rs

@thiagodebastos
Copy link
Author

Sorry, I am still learning rust. I take it this didn't fail locally because I'm using Rust nightly, and the merged RetainMut is only available on nightly?

@archseer
Copy link
Member

archseer commented Apr 6, 2022

Exactly. It'll be stable in two rust releases (target is 1.61.0 rust-lang/rust@c90a947)

@thiagodebastos
Copy link
Author

thiagodebastos commented Apr 6, 2022

@archseer Fantastic, thanks for clearing that up. Should I then close this PR?

@pickfire
Copy link
Contributor

pickfire commented Apr 7, 2022

@archseer
Copy link
Member

archseer commented Apr 7, 2022

Yeah, we'll patch it when it's available

@archseer archseer closed this Apr 7, 2022
@thiagodebastos
Copy link
Author

Thank you for the feedback guys and thank you for the link @pickfire !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants