Skip to content

Commit 2f593fd

Browse files
Jiawen Wugregkh
authored andcommitted
net: wangxun: fix to change Rx features
[ Upstream commit 68067f0 ] Fix the issue where some Rx features cannot be changed. When using ethtool -K to turn off rx offload, it returns error and displays "Could not change any device features". And netdev->features is not assigned a new value to actually configure the hardware. Fixes: 6dbedcf ("net: libwx: Implement xx_set_features ops") Signed-off-by: Jiawen Wu <[email protected]> Reviewed-by: Simon Horman <[email protected]> Signed-off-by: David S. Miller <[email protected]> Signed-off-by: Sasha Levin <[email protected]>
1 parent 941e1c6 commit 2f593fd

File tree

1 file changed

+3
-1
lines changed
  • drivers/net/ethernet/wangxun/libwx

1 file changed

+3
-1
lines changed

drivers/net/ethernet/wangxun/libwx/wx_lib.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2646,12 +2646,14 @@ int wx_set_features(struct net_device *netdev, netdev_features_t features)
26462646
else
26472647
wr32m(wx, WX_RDB_RA_CTL, WX_RDB_RA_CTL_RSS_EN, 0);
26482648

2649+
netdev->features = features;
2650+
26492651
if (changed &
26502652
(NETIF_F_HW_VLAN_CTAG_RX |
26512653
NETIF_F_HW_VLAN_STAG_RX))
26522654
wx_set_rx_mode(netdev);
26532655

2654-
return 1;
2656+
return 0;
26552657
}
26562658
EXPORT_SYMBOL(wx_set_features);
26572659

0 commit comments

Comments
 (0)