Skip to content

Commit 1a7bbda

Browse files
committed
xen/bootup: allow {read|write}_cr8 pvops call.
We actually do not do anything about it. Just return a default value of zero and if the kernel tries to write anything but 0 we BUG_ON. This fixes the case when an user tries to suspend the machine and it blows up in save_processor_state b/c 'read_cr8' is set to NULL and we get: kernel BUG at /home/konrad/ssd/linux/arch/x86/include/asm/paravirt.h:100! invalid opcode: 0000 [#1] SMP Pid: 2687, comm: init.late Tainted: G O 3.6.0upstream-00002-gac264ac-dirty #4 Bochs Bochs RIP: e030:[<ffffffff814d5f42>] [<ffffffff814d5f42>] save_processor_state+0x212/0x270 .. snip.. Call Trace: [<ffffffff810733bf>] do_suspend_lowlevel+0xf/0xac [<ffffffff8107330c>] ? x86_acpi_suspend_lowlevel+0x10c/0x150 [<ffffffff81342ee2>] acpi_suspend_enter+0x57/0xd5 CC: [email protected] Signed-off-by: Konrad Rzeszutek Wilk <[email protected]>
1 parent cd0608e commit 1a7bbda

File tree

1 file changed

+15
-1
lines changed

1 file changed

+15
-1
lines changed

arch/x86/xen/enlighten.c

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -987,7 +987,16 @@ static void xen_write_cr4(unsigned long cr4)
987987

988988
native_write_cr4(cr4);
989989
}
990-
990+
#ifdef CONFIG_X86_64
991+
static inline unsigned long xen_read_cr8(void)
992+
{
993+
return 0;
994+
}
995+
static inline void xen_write_cr8(unsigned long val)
996+
{
997+
BUG_ON(val);
998+
}
999+
#endif
9911000
static int xen_write_msr_safe(unsigned int msr, unsigned low, unsigned high)
9921001
{
9931002
int ret;
@@ -1156,6 +1165,11 @@ static const struct pv_cpu_ops xen_cpu_ops __initconst = {
11561165
.read_cr4_safe = native_read_cr4_safe,
11571166
.write_cr4 = xen_write_cr4,
11581167

1168+
#ifdef CONFIG_X86_64
1169+
.read_cr8 = xen_read_cr8,
1170+
.write_cr8 = xen_write_cr8,
1171+
#endif
1172+
11591173
.wbinvd = native_wbinvd,
11601174

11611175
.read_msr = native_read_msr_safe,

0 commit comments

Comments
 (0)