Fix some PHP CS rules

Author: phansys

.php_cs

@@ -19,8 +19,6 @@ public function transform($number)
         if (TicketMessage::STATUS_CLOSED == $number) {
             return 1;
         }
-
-        return;
     }
 
     /**
@@ -35,7 +33,5 @@ public function reverseTransform($number)
         if (1 == $number) {
             return TicketMessage::STATUS_CLOSED;
         }
-
-        return;
     }
 }

Form/DataTransformer/StatusTransformer.php

@@ -4,6 +4,45 @@
 
 interface TicketMessageInterface
 {
+    const STATUS_INVALID               = 0;
+
+    const STATUS_OPEN                  = 10;
+
+    const STATUS_IN_PROGRESS           = 11;
+
+    const STATUS_INFORMATION_REQUESTED = 12;
+
+    const STATUS_ON_HOLD               = 13;
+
+    const STATUS_RESOLVED              = 14;
+
+    const STATUS_CLOSED                = 15;
+
+    const STATUSES = [
+        self::STATUS_INVALID               => 'STATUS_INVALID',
+        self::STATUS_OPEN                  => 'STATUS_OPEN',
+        self::STATUS_IN_PROGRESS           => 'STATUS_IN_PROGRESS',
+        self::STATUS_INFORMATION_REQUESTED => 'STATUS_INFORMATION_REQUESTED',
+        self::STATUS_ON_HOLD               => 'STATUS_ON_HOLD',
+        self::STATUS_RESOLVED              => 'STATUS_RESOLVED',
+        self::STATUS_CLOSED                => 'STATUS_CLOSED',
+    ];
+
+    const PRIORITY_INVALID = 0;
+
+    const PRIORITY_LOW     = 20;
+
+    const PRIORITY_MEDIUM  = 21;
+
+    const PRIORITY_HIGH    = 22;
+
+    const PRIORITIES = [
+        self::PRIORITY_INVALID => 'PRIORITY_INVALID',
+        self::PRIORITY_LOW     => 'PRIORITY_LOW',
+        self::PRIORITY_MEDIUM  => 'PRIORITY_MEDIUM',
+        self::PRIORITY_HIGH    => 'PRIORITY_HIGH',
+    ];
+
     /**
      * Get id.
      *
@@ -143,43 +182,4 @@ public function setTicket(TicketInterface $ticket = null);
      * @return TicketInterface
      */
     public function getTicket();
-
-    const STATUS_INVALID               = 0;
-
-    const STATUS_OPEN                  = 10;
-
-    const STATUS_IN_PROGRESS           = 11;
-
-    const STATUS_INFORMATION_REQUESTED = 12;
-
-    const STATUS_ON_HOLD               = 13;
-
-    const STATUS_RESOLVED              = 14;
-
-    const STATUS_CLOSED                = 15;
-
-    const STATUSES = [
-        self::STATUS_INVALID               => 'STATUS_INVALID',
-        self::STATUS_OPEN                  => 'STATUS_OPEN',
-        self::STATUS_IN_PROGRESS           => 'STATUS_IN_PROGRESS',
-        self::STATUS_INFORMATION_REQUESTED => 'STATUS_INFORMATION_REQUESTED',
-        self::STATUS_ON_HOLD               => 'STATUS_ON_HOLD',
-        self::STATUS_RESOLVED              => 'STATUS_RESOLVED',
-        self::STATUS_CLOSED                => 'STATUS_CLOSED',
-    ];
-
-    const PRIORITY_INVALID = 0;
-
-    const PRIORITY_LOW     = 20;
-
-    const PRIORITY_MEDIUM  = 21;
-
-    const PRIORITY_HIGH    = 22;
-
-    const PRIORITIES = [
-        self::PRIORITY_INVALID => 'PRIORITY_INVALID',
-        self::PRIORITY_LOW     => 'PRIORITY_LOW',
-        self::PRIORITY_MEDIUM  => 'PRIORITY_MEDIUM',
-        self::PRIORITY_HIGH    => 'PRIORITY_HIGH',
-    ];
 }

Model/TicketMessageInterface.php

@@ -41,7 +41,7 @@ public function testFeatureAttachment($features, $class, $compare)
         $obj = new TicketFeatures($features, $class);
 
         $this->assertInstanceOf(TicketFeatures::class, $obj);
-        $this->assertEquals($obj->hasFeature('attachment'), $compare);
+        $this->assertSame($obj->hasFeature('attachment'), $compare);
     }
 
     public function featureAttachmentProvider()

Tests/Component/TicketFeaturesTest.php

@@ -9,12 +9,12 @@ class ConfigurationTest extends WebTestCase
 {
     private $object;
 
-    public function setUp()
+    protected function setUp()
     {
         $this->object = new Configuration();
     }
 
-    public function tearDown()
+    protected function tearDown()
     {
         unset($this->object);
     }

Tests/DependencyInjection/ConfigurationTest.php

@@ -9,12 +9,12 @@ class HackzillaTicketExtensionTest extends WebTestCase
 {
     private $object;
 
-    public function setUp()
+    protected function setUp()
     {
         $this->object = new HackzillaTicketExtension();
     }
 
-    public function tearDown()
+    protected function tearDown()
     {
         unset($this->object);
     }

Tests/DependencyInjection/HackzillaTicketExtensionTest.php

@@ -9,12 +9,12 @@ class TicketMessageTest extends WebTestCase
 {
     private $object;
 
-    public function setUp()
+    protected function setUp()
     {
         $this->object = new TicketMessage();
     }
 
-    public function tearDown()
+    protected function tearDown()
     {
         unset($this->object);
     }

Tests/Entity/TicketMessageTest.php

@@ -9,12 +9,12 @@ class TicketMessageWithAttachmentTest extends WebTestCase
 {
     private $object;
 
-    public function setUp()
+    protected function setUp()
     {
         $this->object = new TicketMessageWithAttachment();
     }
 
-    public function tearDown()
+    protected function tearDown()
     {
         unset($this->object);
     }

Tests/Entity/TicketMessageWithAttachmentTest.php

@@ -10,12 +10,12 @@ class TicketTest extends WebTestCase
 {
     private $object;
 
-    public function setUp()
+    protected function setUp()
     {
         $this->object = new Ticket();
     }
 
-    public function tearDown()
+    protected function tearDown()
     {
         unset($this->object);
     }

Tests/Entity/TicketTest.php

@@ -10,21 +10,21 @@ class UserLoadTest extends WebTestCase
 {
     private $object;
 
-    public function setUp()
+    protected function setUp()
     {
         $userManager = $this->getUserManagerMock();
 
         $this->object = new UserLoad($userManager);
     }
 
-    public function getUserManagerMock()
+    protected function tearDown()
     {
-        return $this->createMock(UserManager::class);
+        unset($this->object);
     }
 
-    public function tearDown()
+    public function getUserManagerMock()
     {
-        unset($this->object);
+        return $this->createMock(UserManager::class);
     }
 
     public function testObjectCreated()