Confusing checkbox symbol

[2moe]

A minimal example:

use cursive::{
  With,
  views::{Checkbox, ListView, Panel},
};

fn main() {
  let view = ListView::new()
    .child("good?", Checkbox::new())
    .wrap_with(Panel::new);

  cursive::default()
    .with(|siv| siv.add_layer(view))
    .run()
}

TUI should cater to end users, not just developers.
From an average user's perspective, the X symbol is highly confusing.

As a user, I would naturally assume:

- good? [❌] => not good  
- good? [✅] => good  
- good? [ ] => default => good  

But the actual behavior is:

- good? [❌] => good  
- good? [ ] => not good  

Wait! Does that mean "not good" is actually "good"?
This is extremely counterintuitive.

Suggested improvements:
Symbols like [*] or [✔︎] would be far more intuitive than [X].

Implementation proposal:

I recommend exposing a public set_checked_symbol() or with_checked_symbol() method or other configurable way to customize the symbol.

References:

cursive/cursive-core/src/views/checkbox.rs

Line 141 in 8c1f2d3

printer.print((1, 0), "X");

cursive/cursive-core/src/views/radio.rs

Line 227 in 8c1f2d3

printer.print((1, 0), "X");

[gyscos]

Hi, and thanks for the report!

I agree, it would be nice to be able to customize the symbol used here. I used [X] as default like the nmtui tool, but menuconfig uses [*], and I could see more modern tools using [✔︎].