Fixes #3784. SelfContained and NativeAot projects should use the local package in the release mode.

[BDisp]

Fixes

• Fixes SelfContained and NativeAot projects should use the local package in the release mode. #3784

Proposed Changes/Todos

• Provide local packages in release mode

Pull Request checklist:

• I've named my PR in the form of "Fixes #issue. Terse description."
• My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
• My code follows the Terminal.Gui library design guidelines
• I ran dotnet test before commit
• I have made corresponding changes to the API documentation (using /// style comments)
• My changes generate no new warnings
• I have checked my code and corrected any poor grammar or misspellings
• I conducted basic QA to assure all features are working

[BDisp]

@tig I already fixed this issue locally but not yet in the github actions. Can you help me on this please. I don't have experience on this.

[tznind]

Looks like it is currently failing on the windows style local packages?

/home/runner/work/Terminal.Gui/Terminal.Gui/NativeAot/NativeAot.csproj : error NU1301: The local source '/home/runner/work/Terminal.Gui/Terminal.Gui/Terminal.Gui/bin/Release' doesn't exist. [/home/runner/work/Terminal.Gui/Terminal.Gui/Terminal.sln]

If this source should only be used locally when checked out? you can remove it in the CI with:

dotnet nuget remove source LocalPackages

What is the goal of this PR?

To build a nuget package of Terminal.Gui in Release configuration to a directory and have the other two projects reference it?

[BDisp]

What is the goal of this PR?

To build a nuget package of Terminal.Gui in Release configuration to a directory and have the other two projects reference it?

Yes, only for the two projects that use the nuget package. It's to prevent, when the latest nuget version has significant changes, like now, to avoid the fail of these two projects at compile time, locally and in the github CI.

[tznind]

Was this already merged in another PR? it looks quite broken...

I would:

Firstly move the nuget.config file to the subdirectories where its needed i.e. into the NativeAot and SelfContained directories (cut paste). This will prevent everyone trying to use this source even when it doesnt exist yet.

You may need to change the paths e.g. to ../Terminal.Gui/local_packages

Pack only Terminal.Gui:

cd Terminal.Gui && dotnet build --configuration Release
cd Terminal.Gui && dotnet pack --configuration Release --output ./local_packages

Remove the reference in the csproj files and add a new one to the Terminal.Gui in the local packages dir

cd SelfContained
dotnet remove package Terminal.Gui
dotnet add package Terminal.Gui --source LocalPackages

Or since at the moment its a project reference you might need

dotnet remove reference ..\Terminal.Gui\Terminal.Gui.csproj

[BDisp]

The main problem is that the nuget restore is always run first. See NuGet/Home#6746, it seems that it's not possible to use nuget.config per project which respect his configuration, only the one of the solution will be used.

[tznind]

The closest one to the code is used I think so if you move it to subdirectory it will be used. Basically when you are cd into the directory and building it will use the one that is in the current directory otherwise it will look at parent directory.

[BDisp]

The closest one to the code is used I think so if you move it to subdirectory it will be used. Basically when you are cd into the directory and building it will use the one that is in the current directory otherwise it will look at parent directory.

Yes I know, but normally dotnet build --configuration Release is done in the solution location and is the nuget.confile in that folder that will be used, I think. Feel free to submit your own PR that could fix this locally and in the CI and I will close, mine. In mean wile I'll continue to discover any solution that can solve this. Thanks.

Note: I did a cherry-pick of this commit d77b899 in this PR.

[tznind]

Here is a first pass

https://github.com/BDisp/Terminal.Gui/pull/200/files

[BDisp]

Here is a first pass

https://github.com/BDisp/Terminal.Gui/pull/200/files

I can't merge it. When you have sure it work mark as ready for review, please. Thanks.

[BDisp]

I think I found a simpler solution for this. We cannot avoid the dotnet build running immediately the package restore, avoiding the pre-build take the necessary tasks for build and pack the Terminal.Gui in release and thus, NativeAot and SelfContained projects restoring the packages with available package sources. The solution I found was creating a .ps1 file for Windows and .sh file for Linux and Mac. When we need to build a release version then we use that files for build and pack and then restore and build NativeAot and SelfContained projects.

[tig]

Is this ready or not?

[BDisp]

Is this ready or not?

Yes it's.

[BDisp]

If you don't mind it will useful to merge this to avoid all the CI errors. Thanks.

[tig]

@BDisp Release build is still failing

[BDisp]

@BDisp Release build is still failing

Solution here #3790 (comment).