Fix for Array.prototype.push encountering a "Maximum Call Stack Exceeded" error when the input is a large number of HTML character entities

Fixes #171

Author: gregjacobs

src/htmlParser/HtmlParser.js

@@ -156,7 +156,14 @@ Autolinker.htmlParser.HtmlParser = Autolinker.Util.extend( Object, {
 			// Push TextNodes and EntityNodes for any text found between tags
 			if( text ) {
 				textAndEntityNodes = this.parseTextAndEntityNodes( lastIndex, text );
-				nodes.push.apply( nodes, textAndEntityNodes );
+
+				// Note: the following 3 lines were previously:
+				//   nodes.push.apply( nodes, textAndEntityNodes );
+				// but this was causing a "Maximum Call Stack Size Exceeded"
+				// error on inputs with a large number of html entities.
+				textAndEntityNodes.forEach( function( node ) {
+					nodes.push( node );
+				} );
 			}
 		}
 

tests/AutolinkerSpec.js

@@ -1489,6 +1489,22 @@ describe( "Autolinker", function() {
 			} );
 
 
+			it( "should not fail with a Maximum Call Stack Size Exceeded for an " +
+				"input with a large number of html entities (Issue #171)",
+			function() {
+				var testStr = (function() {
+					var t = [];
+					for (var i = 0; i < 50000; i++) {
+						t.push( ' /&gt;&lt;br' );
+					}
+					return t.join( '' );
+				})();
+
+				var result = autolinker.link( testStr );
+				expect( result ).toBe( testStr );
+			} );
+
+
 			it( "should NOT modify the email address with other tags when inside another anchor", function() {
 				var input = [
 					'<div>First name: Subin</div>',