Add check for negative name indices in flamebearer profiles (#3324)

Author: aleks-p

pkg/og/structs/flamebearer/flamebearer.go

@@ -291,6 +291,9 @@ func (fb FlamebearerProfileV1) Validate() error {
 			if l[i] >= len(fb.Flamebearer.Names) {
 				return fmt.Errorf("invalid name index %d, it should be smaller than %d", l[i], len(fb.Flamebearer.Levels))
 			}
+			if l[i] < 0 {
+				return fmt.Errorf("invalid name index %d, it should be a non-negative value", l[i])
+			}
 		}
 	}
 	return nil

pkg/og/structs/flamebearer/flamebearer_test.go

@@ -344,6 +344,21 @@ var _ = Describe("Checking profile validation", func() {
 		})
 	})
 
+	When("the name index is negative", func() {
+		Context("and we validate a single profile", func() {
+			var fb FlamebearerProfile
+			BeforeEach(func() {
+				fb.Metadata.Format = "single"
+				fb.Flamebearer.Names = []string{"name"}
+				fb.Flamebearer.Levels = [][]int{{0, 0, 0, -1}}
+			})
+
+			It("returns an error", func() {
+				Expect(fb.Validate()).To(MatchError("invalid name index -1, it should be a non-negative value"))
+			})
+		})
+	})
+
 	When("everything is valid", func() {
 		Context("and we validate a single profile", func() {
 			var fb FlamebearerProfile