Skip to content

Commit a0cfe0f

Browse files
authored
Upgrade pyroscope-nodejs to v0.2.9 (#3032)
* Fix memory collection for express-pull example * Upgrade pyroscope-nodejs to v0.2.9 * Remove unused dependencies after pr review
1 parent 2a03044 commit a0cfe0f

File tree

13 files changed

+1047
-592
lines changed

13 files changed

+1047
-592
lines changed

examples/language-sdk-instrumentation/nodejs/express-pull/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ FROM node:latest
22

33
WORKDIR /app
44

5-
COPY package.json .
6-
RUN npm install
5+
COPY package.json yarn.lock .
6+
RUN yarn install
77
COPY index.js .
88

99
ENV DEBUG=pyroscope

examples/language-sdk-instrumentation/nodejs/express-pull/agent.config.river

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,4 +26,9 @@ pyroscope.scrape "default" {
2626
{"__address__" = "ap-south:5000", "service_name"="nodejs"},
2727
]
2828
forward_to = [pyroscope.write.example.receiver]
29+
profiling_config {
30+
profile.memory { // disable memory, use godeltaprof_memory instead
31+
path = "/debug/pprof/heap"
32+
}
33+
}
2934
}

examples/language-sdk-instrumentation/nodejs/express-pull/docker-compose.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ services:
88
agent:
99
image: grafana/agent:latest
1010
volumes:
11-
- ./agent.config.river:/etc/agent-config/config.river
11+
- ./agent.config.river:/etc/agent-config/config.river:ro
1212
command:
1313
- run
1414
- /etc/agent-config/config.river

examples/language-sdk-instrumentation/nodejs/express-pull/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,7 @@
1111
"dependencies": {
1212
"@pyroscope/nodejs": "^0.2.x",
1313
"express": "^4.17.3",
14-
"morgan": "^1.10.0",
15-
"pprof": "^3.2.0"
14+
"morgan": "^1.10.0"
1615
},
1716
"resolutions": {
1817
"protobufjs": "^7.2.4"

examples/language-sdk-instrumentation/nodejs/express-pull/yarn.lock

Lines changed: 184 additions & 86 deletions
Large diffs are not rendered by default.

examples/language-sdk-instrumentation/nodejs/express-ts/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ FROM node:latest
22

33
WORKDIR /app
44

5-
COPY package.json .
5+
COPY package.json yarn.lock .
66
COPY tsconfig.json .
77
RUN yarn
88
COPY *.ts .

examples/language-sdk-instrumentation/nodejs/express-ts/package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,8 @@
1111
"license": "Apache-2.0",
1212
"dependencies": {
1313
"@pyroscope/nodejs": "^0.2.x",
14-
"axios": "^0.26.1",
1514
"express": "^4.17.3",
1615
"morgan": "^1.10.0",
17-
"pprof": "^3.2.0",
1816
"typescript": "^4.6.2"
1917
},
2018
"devDependencies": {

examples/language-sdk-instrumentation/nodejs/express-ts/yarn.lock

Lines changed: 423 additions & 246 deletions
Large diffs are not rendered by default.

examples/language-sdk-instrumentation/nodejs/express/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ FROM node:latest
22

33
WORKDIR /app
44

5-
COPY package.json .
6-
RUN npm install
5+
COPY package.json yarn.lock .
6+
RUN yarn install
77
COPY index.js .
88

99
ENV DEBUG=pyroscope

examples/language-sdk-instrumentation/nodejs/express/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,7 @@
1111
"dependencies": {
1212
"@pyroscope/nodejs": "^0.2.x",
1313
"express": "^4.17.3",
14-
"morgan": "^1.10.0",
15-
"pprof": "^3.2.0"
14+
"morgan": "^1.10.0"
1615
},
1716
"resolutions": {
1817
"protobufjs": "^7.2.4"

0 commit comments

Comments
 (0)