Skip to content

Commit 80bab17

Browse files
authored
fix: add IPv6 support in missing places (#3919)
1 parent a4297db commit 80bab17

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

pkg/api/version/version.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ import (
44
"context"
55
"fmt"
66
"math"
7+
"net"
8+
"strconv"
79
"sync"
810
"time"
911

@@ -187,7 +189,7 @@ func New(cfg util.CommonRingConfig, logger log.Logger, reg prometheus.Registerer
187189
svc := &Service{
188190
store: client,
189191
id: cfg.InstanceID,
190-
addr: fmt.Sprintf("%s:%d", instanceAddr, instancePort),
192+
addr: net.JoinHostPort(instanceAddr, strconv.Itoa(instancePort)),
191193
cfg: cfg,
192194
logger: log.With(logger, "component", "versions"),
193195
cancel: cancel,

pkg/frontend/frontend.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,9 @@ import (
1010
"flag"
1111
"fmt"
1212
"math/rand"
13+
"net"
1314
"net/http"
15+
"strconv"
1416
"sync"
1517
"time"
1618

@@ -145,7 +147,7 @@ type enqueueResult struct {
145147
func NewFrontend(cfg Config, limits Limits, log log.Logger, reg prometheus.Registerer) (*Frontend, error) {
146148
requestsCh := make(chan *frontendRequest)
147149

148-
schedulerWorkers, err := newFrontendSchedulerWorkers(cfg, fmt.Sprintf("%s:%d", cfg.Addr, cfg.Port), requestsCh, log, reg)
150+
schedulerWorkers, err := newFrontendSchedulerWorkers(cfg, net.JoinHostPort(cfg.Addr, strconv.Itoa(cfg.Port)), requestsCh, log, reg)
149151
if err != nil {
150152
return nil, err
151153
}

0 commit comments

Comments
 (0)