Add tests

Author: aocenas

grafana/fire-datasource/pkg/plugin/plugin_test.go

@@ -1,17 +1,16 @@
-package plugin_test
+package plugin
 
 import (
 	"context"
 	"testing"
 
 	"github.com/grafana/grafana-plugin-sdk-go/backend"
-
-	"github.com/grafana/fire/grafana/fire-datasource/pkg/plugin"
+	"github.com/stretchr/testify/require"
 )
 
 // This is where the tests for the datasource backend live.
-func TestQueryData(t *testing.T) {
-	ds := plugin.FireDatasource{}
+func Test_QueryData(t *testing.T) {
+	ds := FireDatasource{}
 
 	resp, err := ds.QueryData(
 		context.Background(),
@@ -29,3 +28,37 @@ func TestQueryData(t *testing.T) {
 		t.Fatal("QueryData must return a response")
 	}
 }
+
+func Test_CallResource(t *testing.T) {
+	ds := &FireDatasource{
+		client: &FakeClient{},
+	}
+
+	t.Run("series resource", func(t *testing.T) {
+		sender := &FakeSender{}
+		err := ds.CallResource(
+			context.Background(),
+			&backend.CallResourceRequest{
+				PluginContext: backend.PluginContext{},
+				Path:          "series",
+				Method:        "GET",
+				URL:           "series?matchers=%7B%7D",
+				Headers:       nil,
+				Body:          nil,
+			},
+			sender,
+		)
+		require.NoError(t, err)
+		require.Equal(t, 200, sender.Resp.Status)
+		require.Equal(t, `[{"labels":[{"name":"instance","value":"127.0.0.1"},{"name":"job","value":"default"}]}]`, string(sender.Resp.Body))
+	})
+}
+
+type FakeSender struct {
+	Resp *backend.CallResourceResponse
+}
+
+func (fs *FakeSender) Send(resp *backend.CallResourceResponse) error {
+	fs.Resp = resp
+	return nil
+}

grafana/fire-datasource/pkg/plugin/query_test.go

@@ -6,6 +6,7 @@ import (
 	"time"
 
 	"github.com/bufbuild/connect-go"
+	v1 "github.com/grafana/fire/pkg/gen/common/v1"
 	querierv1 "github.com/grafana/fire/pkg/gen/querier/v1"
 	"github.com/grafana/grafana-plugin-sdk-go/backend"
 	"github.com/grafana/grafana-plugin-sdk-go/data"
@@ -73,7 +74,26 @@ func (f FakeClient) LabelValues(ctx context.Context, c *connect.Request[querierv
 }
 
 func (f FakeClient) Series(ctx context.Context, c *connect.Request[querierv1.SeriesRequest]) (*connect.Response[querierv1.SeriesResponse], error) {
-	panic("implement me")
+	return &connect.Response[querierv1.SeriesResponse]{
+		Msg: &querierv1.SeriesResponse{
+			LabelsSet: []*v1.Labels{{
+				Labels: []*v1.LabelPair{
+					{
+						Name:  "__unit__",
+						Value: "cpu",
+					},
+					{
+						Name:  "instance",
+						Value: "127.0.0.1",
+					},
+					{
+						Name:  "job",
+						Value: "default",
+					},
+				},
+			}},
+		},
+	}, nil
 }
 
 func (f FakeClient) SelectMergeStacktraces(ctx context.Context, c *connect.Request[querierv1.SelectMergeStacktracesRequest]) (*connect.Response[querierv1.SelectMergeStacktracesResponse], error) {

grafana/fire-datasource/src/QueryEditor/LabelsEditor.tsx

@@ -7,7 +7,7 @@ import { useAsync } from 'react-use';
 
 import { languageDefinition } from '../fireql';
 import { FireDataSource } from '../datasource';
-import { CompletionProvider } from './autocompletition';
+import { CompletionProvider } from './autocomplete';
 
 interface Props {
   value: string;

grafana/fire-datasource/src/QueryEditor/autocomplete.test.ts

@@ -0,0 +1,88 @@
+import { CompletionProvider } from './autocomplete';
+import { SeriesMessage } from '../types';
+import { monacoTypes } from '@grafana/ui';
+
+describe('CompletionProvider', () => {
+  it('suggests labels', () => {
+    const { provider, model } = setup('{}', 1, defaultLabels);
+    const result = provider.provideCompletionItems(model as any, {} as any);
+    expect((result! as monacoTypes.languages.CompletionList).suggestions).toEqual([
+      expect.objectContaining({ label: 'foo', insertText: 'foo' }),
+    ]);
+  });
+
+  it('suggests label names with quotes', () => {
+    const { provider, model } = setup('{foo=}', 6, defaultLabels);
+    const result = provider.provideCompletionItems(model as any, {} as any);
+    expect((result! as monacoTypes.languages.CompletionList).suggestions).toEqual([
+      expect.objectContaining({ label: 'bar', insertText: '"bar"' }),
+    ]);
+  });
+
+  it('suggests label names without quotes', () => {
+    const { provider, model } = setup('{foo="}', 7, defaultLabels);
+    const result = provider.provideCompletionItems(model as any, {} as any);
+    expect((result! as monacoTypes.languages.CompletionList).suggestions).toEqual([
+      expect.objectContaining({ label: 'bar', insertText: 'bar' }),
+    ]);
+  });
+
+  it('suggests nothing without labels', () => {
+    const { provider, model } = setup('{foo="}', 7, []);
+    const result = provider.provideCompletionItems(model as any, {} as any);
+    expect((result! as monacoTypes.languages.CompletionList).suggestions).toEqual([]);
+  });
+
+  it('suggests labels on empty input', () => {
+    const { provider, model } = setup('', 0, defaultLabels);
+    const result = provider.provideCompletionItems(model as any, {} as any);
+    expect((result! as monacoTypes.languages.CompletionList).suggestions).toEqual([
+      expect.objectContaining({ label: 'foo', insertText: '{foo="' }),
+    ]);
+  });
+});
+
+const defaultLabels = [{ labels: [{ name: 'foo', value: 'bar' }] }];
+
+function setup(value: string, offset: number, series?: SeriesMessage) {
+  const provider = new CompletionProvider();
+  if (series) {
+    provider.setSeries(series);
+  }
+  const model = makeModel(value, offset);
+  provider.monaco = {
+    Range: {
+      fromPositions() {
+        return null;
+      },
+    },
+    languages: {
+      CompletionItemKind: {
+        Enum: 1,
+        EnumMember: 2,
+      },
+    },
+  } as any;
+  provider.editor = {
+    getModel() {
+      return model;
+    },
+  } as any;
+
+  return { provider, model };
+}
+
+function makeModel(value: string, offset: number) {
+  return {
+    id: 'test_monaco',
+    getWordAtPosition() {
+      return null;
+    },
+    getOffsetAt() {
+      return offset;
+    },
+    getValue() {
+      return value;
+    },
+  };
+}

grafana/fire-datasource/src/QueryEditor/autocompletition.tsx renamed to grafana/fire-datasource/src/QueryEditor/autocomplete.tsx

@@ -1,4 +1,5 @@
-import type { Monaco, monacoTypes } from '@grafana/ui';
+import type { Monaco } from '@grafana/ui';
+import { monacoTypes } from '@grafana/ui';
 import { SeriesMessage } from '../types';
 
 /**