chore(engine): use github.com/grafana/dskit/dns for scheduler discovery #19835
+179
−130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, workers used github.com/grafana/dskit/grpcutil for scheduler discovery. This was an older package which, through how we used it, didn't permit SRV lookups. Other code within Loki instead uses the dns package from dskit for discovery. This package has better support for SRV lookups and supports flags like `dnssrvnoa+` for forcing a SRV lookup with no A records. This commit updates workers to use this package instead. As part of this change, the test code has been updated to use testing/synctest for more easy and reliably testing of the background discovery process. Signed-off-by: Robert Fratto <[email protected]>
chaudum
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, workers used github.com/grafana/dskit/grpcutil for scheduler discovery. This was an older package which, through how we used it, didn't permit SRV lookups.
Other code within Loki instead uses the dns package from dskit for discovery. This package has better support for SRV lookups and supports flags like
dnssrvnoa+for forcing a SRV lookup with no A records.This commit updates workers to use this package instead.
As part of this change, the test code has been updated to use testing/synctest for more easy and reliably testing of the background discovery process.