-
Notifications
You must be signed in to change notification settings - Fork 3.9k
fix(helm): Fix incorrect context references in Helm storage templates #18740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+12
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Helm Diff Output - SummaryDefault Values Scenario-diff-outputDistributed Scenario-diff-outputIngress Values Scenario-diff-outputLegacy Monitoring Values Scenario-diff-outputSimple Scalable AWS Kube IRSA Values Scenario-diff-outputSimple Thanos Values Scenario-diff-output580,590c580
< access_key_id: thanos-minio
< bucket_name: ruler_thanos
< endpoint: http://minio.minio.svc.cluster.local:9000
< http:
< tls_config:
< insecure_skip_verify: true
< insecure: true
< region: us-east-1
< secret_access_key: thanos-minio123
< sse: {}
< storage_prefix: null
---
> bucketnames: ruler
1249c1239
< checksum/config: 14faca847f0abec438f528ba5bab3e686aeb7c8327a471139b65a159d32a9209
---
> checksum/config: ac0586877c272c058aadbc86ce9bb614e3cf2586fdc12c4456fcac8032b42e72
1355c1345
< checksum/config: 14faca847f0abec438f528ba5bab3e686aeb7c8327a471139b65a159d32a9209
---
> checksum/config: ac0586877c272c058aadbc86ce9bb614e3cf2586fdc12c4456fcac8032b42e72
1459c1449
< checksum/config: 14faca847f0abec438f528ba5bab3e686aeb7c8327a471139b65a159d32a9209
---
> checksum/config: ac0586877c272c058aadbc86ce9bb614e3cf2586fdc12c4456fcac8032b42e72
1675c1665
< checksum/config: 14faca847f0abec438f528ba5bab3e686aeb7c8327a471139b65a159d32a9209
---
> checksum/config: ac0586877c272c058aadbc86ce9bb614e3cf2586fdc12c4456fcac8032b42e72
2091c2081
< checksum/config: 14faca847f0abec438f528ba5bab3e686aeb7c8327a471139b65a159d32a9209
---
> checksum/config: ac0586877c272c058aadbc86ce9bb614e3cf2586fdc12c4456fcac8032b42e72Single Binary Scenario-diff-output |
6 tasks
jkroepke
reviewed
Aug 6, 2025
jkroepke
reviewed
Aug 6, 2025
Contributor
jkroepke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Jan-Otto Kröpke <[email protected]> Signed-off-by: J Stickler <[email protected]>
Signed-off-by: J Stickler <[email protected]>
JStickler
approved these changes
Aug 6, 2025
6 tasks
This was referenced Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Problem:
The Helm template _helpers.tpl contained incorrect context references (.ctx.ctx.Values) for several storage types that would cause template rendering failures.
Solution: Fixed context references from .ctx.ctx.Values to .ctx.Values for:
alibabacloud storage type
swift storage type
bos storage type
cos storage type
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR