Skip to content

Conversation

@Jayclifford345
Copy link
Contributor

What this PR does / why we need it:
Problem:
The Helm template _helpers.tpl contained incorrect context references (.ctx.ctx.Values) for several storage types that would cause template rendering failures.

Solution: Fixed context references from .ctx.ctx.Values to .ctx.Values for:
alibabacloud storage type
swift storage type
bos storage type
cos storage type

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@Jayclifford345 Jayclifford345 requested a review from a team as a code owner August 6, 2025 19:07
@Jayclifford345 Jayclifford345 changed the title Fix helm types fix(helm): Fix incorrect context references in Helm storage templates Aug 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025

Helm Diff Output - Summary

Default Values Scenario-diff-output
Distributed Scenario-diff-output
Ingress Values Scenario-diff-output
Legacy Monitoring Values Scenario-diff-output
Simple Scalable AWS Kube IRSA Values Scenario-diff-output
Simple Thanos Values Scenario-diff-output
580,590c580
<           access_key_id: thanos-minio
<           bucket_name: ruler_thanos
<           endpoint: http://minio.minio.svc.cluster.local:9000
<           http:
<             tls_config:
<               insecure_skip_verify: true
<           insecure: true
<           region: us-east-1
<           secret_access_key: thanos-minio123
<           sse: {}
<         storage_prefix: null
---
>           bucketnames: ruler
1249c1239
<         checksum/config: 14faca847f0abec438f528ba5bab3e686aeb7c8327a471139b65a159d32a9209
---
>         checksum/config: ac0586877c272c058aadbc86ce9bb614e3cf2586fdc12c4456fcac8032b42e72
1355c1345
<         checksum/config: 14faca847f0abec438f528ba5bab3e686aeb7c8327a471139b65a159d32a9209
---
>         checksum/config: ac0586877c272c058aadbc86ce9bb614e3cf2586fdc12c4456fcac8032b42e72
1459c1449
<         checksum/config: 14faca847f0abec438f528ba5bab3e686aeb7c8327a471139b65a159d32a9209
---
>         checksum/config: ac0586877c272c058aadbc86ce9bb614e3cf2586fdc12c4456fcac8032b42e72
1675c1665
<         checksum/config: 14faca847f0abec438f528ba5bab3e686aeb7c8327a471139b65a159d32a9209
---
>         checksum/config: ac0586877c272c058aadbc86ce9bb614e3cf2586fdc12c4456fcac8032b42e72
2091c2081
<         checksum/config: 14faca847f0abec438f528ba5bab3e686aeb7c8327a471139b65a159d32a9209
---
>         checksum/config: ac0586877c272c058aadbc86ce9bb614e3cf2586fdc12c4456fcac8032b42e72
Single Binary Scenario-diff-output

Copy link
Contributor

@jkroepke jkroepke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JStickler JStickler merged commit 1f362c8 into main Aug 6, 2025
77 checks passed
@JStickler JStickler deleted the fix-helm-types branch August 6, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants