Skip to content

Conversation

@ashwanthgoli
Copy link
Contributor

This reverts commit 87aa954.

What this PR does / why we need it:

Reverts #17628 as it seems to be affecting the correctness of forward queries. The exact problem is not well understood yet, but we suspect that we are closing wrapped iterator before consuming all of the required entires

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@ashwanthgoli ashwanthgoli requested a review from a team as a code owner August 1, 2025 07:14
@ashwanthgoli ashwanthgoli changed the title Revert "perf: Fix memory leak in cachedIterator (#17628)" fix: Revert "perf: Fix memory leak in cachedIterator (#17628)" Aug 1, 2025
@ashwanthgoli ashwanthgoli force-pushed the revert-fwd-query-bug branch from 1d52d2b to b7f7880 Compare August 1, 2025 07:16
@ashwanthgoli ashwanthgoli added the type/bug Somehing is not working as expected label Aug 1, 2025
@ashwanthgoli ashwanthgoli merged commit 0316740 into main Aug 1, 2025
68 checks passed
@ashwanthgoli ashwanthgoli deleted the revert-fwd-query-bug branch August 1, 2025 07:25
loki-gh-app bot pushed a commit that referenced this pull request Aug 1, 2025
loki-gh-app bot pushed a commit that referenced this pull request Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport k264 backport k265 size/XS type/bug Somehing is not working as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants