-
Notifications
You must be signed in to change notification settings - Fork 3.8k
fix(docs): added instructions for how to upgrade zone-aware ingesters #18658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💻 Deploy preview deleted. |
Helm Diff Output - SummaryDefault Values Scenario-diff-outputDistributed Scenario-diff-outputIngress Values Scenario-diff-outputLegacy Monitoring Values Scenario-diff-outputSimple Scalable AWS Kube IRSA Values Scenario-diff-outputSimple Thanos Values Scenario-diff-outputSingle Binary Scenario-diff-output |
fcjack
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@JStickler, this will need a backport to the latest :) |
|
Hello @JStickler!
Please, if the current pull request addresses a bug fix, label it with the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-18658-to-release-3.5.x origin/release-3.5.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x aff2cb0694cae99847b73da914ee4abd2432cdd0When the conflicts are resolved, stage and commit the changes: If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-18658-to-release-3.5.x
# Create the PR body template
PR_BODY=$(gh pr view 18658 --json body --template 'Backport aff2cb0694cae99847b73da914ee4abd2432cdd0 from #18658{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title 'fix(docs): added instructions for how to upgrade zone-aware ingesters (backport release-3.5.x)' --body-file - --label 'size/M' --label 'type/docs' --label 'backport' --base release-3.5.x --milestone release-3.5.x --webOr, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-18658-to-release-3.5.x
# Create a pull request where the `base` branch is `release-3.5.x` and the `compare`/`head` branch is `backport-18658-to-release-3.5.x`.
# Remove the local backport branch
git switch main
git branch -D backport-18658-to-release-3.5.x |
…grafana#18658) (cherry picked from commit aff2cb0)
What this PR does / why we need it:
Added upgrade notice for: #18558
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR