feat(helm): Expose all storage configuration #18509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkroepke
force-pushed
the
helm/storage-config
branch
from
d6e699e to
8efde0b
Compare
jkroepke
commented
Jul 20, 2025
| {{- if .Values.minio.enabled -}} | ||
| type: "s3" | ||
| s3: | ||
| bucketnames: ruler |
Contributor
There was a problem hiding this comment.
Suggested change
| bucketnames: ruler | |
| bucketnames: {{ .Values.loki.storage.bucketNames.ruler }} |
Contributor
Author
There was a problem hiding this comment.
Same here, bucket names with internal minio deployment are hard-coded
loki/production/helm/loki/values.yaml
Lines 3532 to 3541 in ce03b79
| azure: | ||
| account_name: {{ .accountName }} | ||
| {{- toYaml (mergeOverwrite | ||
| dict |
Contributor
There was a problem hiding this comment.
this is not easily readable 🤔 Can we do it a bit differently? Maybe azure, gcs and s3 could be extracted into separate templates for better readibility?
Contributor
Author
There was a problem hiding this comment.
please check this out if it meets your expectations
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Co-authored-by: Quentin Bisson <[email protected]> Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jay Clifford <[email protected]>
Contributor
|
Just kicking off the workflows for this one again. Thanks for your efforts here, both. Let me know when you are ready for it to be merged |
Contributor
|
LGTM, nice work @jkroepke |
jkroepke
commented
Jul 28, 2025
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: J Stickler <[email protected]>
This was referenced Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR exposes all storage properties similar to #17597. It also adds an backwards compatibility layer to preserve old camelCase values naming.
It should also cover some PR related to exposing newer storage properties.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR