feat: return ReasonFailed from ingest-limits frontend #18123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| logger: logger, | ||
| gatherer: gatherer, | ||
| assignedPartitionsCache: assignedPartitionsCache, | ||
| streams: promauto.With(reg).NewCounter( |
Contributor
Author
There was a problem hiding this comment.
Thanks to this I was able to move the metrics out of ring.go and into frontend.go.
|
|
||
| // ReasonMaxStreams is returned when a stream cannot be accepted because | ||
| // the tenant has either reached or exceeded their maximum stream limit. | ||
| ReasonMaxStreams |
Contributor
Author
There was a problem hiding this comment.
Renamed to remove the Exceeds.
| ReasonExceedsMaxStreams Reason = iota | ||
| // ReasonFailed is the reason returned when a stream cannot be checked | ||
| // against limits due to an error. | ||
| ReasonFailed Reason = iota + 1 |
Contributor
Author
There was a problem hiding this comment.
This should have been iota + 1 to start with, made a mistake here.
grobinson-grafana
force-pushed
the
grobinson/return-failed-reason
branch
from
e750fdb to
3c63b26
Compare
6 tasks
| for _, resp := range resps { | ||
| results = append(results, resp.Results...) | ||
| // If the entire call failed, then all streams failed. | ||
| for _, stream := range req.Streams { |
Contributor
Author
There was a problem hiding this comment.
This is implemented as per https://github.com/grafana/deployment_tools/blob/master/docs/loki/limits.md#apis.
periklis
approved these changes
Jun 17, 2025
This commit updates the ingest-limits frontend to return streams with ReasonFailed if that stream could not be checked against per-tenant limits.
grobinson-grafana
force-pushed
the
grobinson/return-failed-reason
branch
from
3c63b26 to
821730b
Compare
This was referenced Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This commit updates the ingest-limits frontend to return streams with
ReasonFailedif that stream could not be checked against per-tenant limits.Stack on top of #18055.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR