-
Notifications
You must be signed in to change notification settings - Fork 3.8k
fix: enable ui in helm deployments #17562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The Loki UI is very experimental. I'm not sure that we want to update the Helm chart to support it yet. |
I guess why include it in the values file as an option then? - my point is that the current chart does not function as expected so either the UI flag should be removed from values, or it should be fixed. |
sure I suppose that works as well Co-authored-by: Thomas Decaux <[email protected]> Signed-off-by: Rogly <[email protected]>
|
Fair point @rogly, would you mind resolving the conflict in the change log? I have kicked off the automatic tests. If they pass we can get this merged |
Signed-off-by: Rogly <[email protected]>
@Jayclifford345 Conflict should be resolved now. |
|
Sorry for the late reply on this one it missed my inbox. I have enabled auto-merge once all the tests pass |
|
Hey sorry @rogly, please run make helm-docsAt the top of the loki repo to update the docs |
Will test with grafana/loki#17562 later
What this PR does / why we need it:
ui.enabledtoTrueto Loki ConfigMap whenloki.ui.enabledis set toTrueto enable UI on pods deployed by the chart.Which issue(s) this PR fixes:
Fixes #17561
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR