Skip to content

Commit 82281ec

Browse files
committed
Switch Groovy script evaluation order
It makes more sense for the project one to be executed last in order to override
1 parent 7cdb3cc commit 82281ec

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,8 @@ captured and under which conditions.
6060
You can apply additional configuration beyond what is contributed by the Common Custom User Data Maven extension by default.
6161
The extension evaluates Groovy scripts from two locations:
6262

63-
1. A `.mvn/develocity-custom-user-data.groovy` or `.mvn/gradle-enterprise-custom-user-data.groovy` in your root project
64-
2. Any `*.groovy` files in the `custom-user-data` directory, located within the [Develocity storage directory](https://docs.gradle.com/develocity/maven-extension/current/#anatomy_of_the_develocity_directory), `${user.home}/.m2/.develocity` by default
63+
1. Any `*.groovy` files in the `custom-user-data` directory, located within the [Develocity storage directory](https://docs.gradle.com/develocity/maven-extension/current/#anatomy_of_the_develocity_directory), `${user.home}/.m2/.develocity` by default
64+
2. A `.mvn/develocity-custom-user-data.groovy` or `.mvn/gradle-enterprise-custom-user-data.groovy` in your root project
6565

6666
All matching files are evaluated with the following bindings:
6767

src/main/java/com/gradle/GroovyScriptUserData.java

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,17 @@
1717
final class GroovyScriptUserData {
1818

1919
static void evaluate(MavenSession session, DevelocityAdapter develocity, Logger logger, CustomConfigurationSpec customConfigurationSpec) throws MavenExecutionException {
20-
evaluateGroovyScriptInRootProject(session, develocity, logger, customConfigurationSpec);
2120
evaluateGroovyScriptsInDevelocityStorageDirectory(session, develocity, logger, customConfigurationSpec);
21+
evaluateGroovyScriptInRootProject(session, develocity, logger, customConfigurationSpec);
22+
}
23+
24+
private static void evaluateGroovyScriptsInDevelocityStorageDirectory(MavenSession session, DevelocityAdapter develocity, Logger logger, CustomConfigurationSpec customConfigurationSpec) throws MavenExecutionException {
25+
File customUserDataDirectory = develocity.getStorageDirectory().resolve("custom-user-data").toFile();
26+
List<File> scripts = getGroovyScripts(customUserDataDirectory);
27+
for (File script : scripts) {
28+
logger.debug("Evaluating custom user data Groovy script: {}", script);
29+
evaluateGroovyScript(session, develocity, logger, script, customConfigurationSpec.apiVariableName);
30+
}
2231
}
2332

2433
private static void evaluateGroovyScriptInRootProject(MavenSession session, DevelocityAdapter develocity, Logger logger, CustomConfigurationSpec customConfigurationSpec) throws MavenExecutionException {
@@ -40,15 +49,6 @@ private static void evaluateGroovyScriptInRootProject(MavenSession session, Deve
4049
}
4150
}
4251

43-
private static void evaluateGroovyScriptsInDevelocityStorageDirectory(MavenSession session, DevelocityAdapter develocity, Logger logger, CustomConfigurationSpec customConfigurationSpec) throws MavenExecutionException {
44-
File customUserDataDirectory = develocity.getStorageDirectory().resolve("custom-user-data").toFile();
45-
List<File> scripts = getGroovyScripts(customUserDataDirectory);
46-
for (File script : scripts) {
47-
logger.debug("Evaluating custom user data Groovy script: {}", script);
48-
evaluateGroovyScript(session, develocity, logger, script, customConfigurationSpec.apiVariableName);
49-
}
50-
}
51-
5252
private static File getGroovyScript(MavenSession session, String scriptName) {
5353
File rootDir = session.getRequest().getMultiModuleProjectDirectory();
5454
return new File(rootDir, ".mvn/" + scriptName + ".groovy");

0 commit comments

Comments
 (0)