Merge pull request #301 from thedadams/better-display-name

thedadams · web-flow · commit 8bc816e83e86 · 2024-08-27T13:57:41.000-04:00
fix: properly update display names for tool dropdown
diff --git a/components/scripts/tool-dropdown.tsx b/components/scripts/tool-dropdown.tsx
@@ -30,18 +30,18 @@ const ScriptToolsDropdown = () => {
           load(tool).then((loadedTool) => {
             const loadedName = loadedTool.toolSet[loadedTool.entryToolId].name;
             if (loadedName) {
-              setDisplayNames({
-                ...displayNames,
+              setDisplayNames((prev) => ({
+                ...prev,
                 [tool]: loadedName,
-              });
+              }));
             }
           });
         }
       }
     }
 
     setThreadTools(threadTools);
-  }, [tools]);
+  }, [tools, displayNames, knowledgeGatewayTool]);
 
   function getDisplayName(ref: string): string {
     return (

Original file line number	Diff line number	Diff line change
`@@ -30,18 +30,18 @@ const ScriptToolsDropdown = () => {`
`30`	`30`	`load(tool).then((loadedTool) => {`
`31`	`31`	`const loadedName = loadedTool.toolSet[loadedTool.entryToolId].name;`
`32`	`32`	`if (loadedName) {`
`33`		`- setDisplayNames({`
`34`		`- ...displayNames,`
	`33`	`+ setDisplayNames((prev) => ({`
	`34`	`+ ...prev,`
`35`	`35`	`[tool]: loadedName,`
`36`		`- });`
	`36`	`+ }));`
`37`	`37`	`}`
`38`	`38`	`});`
`39`	`39`	`}`
`40`	`40`	`}`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`setThreadTools(threadTools);`
`44`		`- }, [tools]);`
	`44`	`+ }, [tools, displayNames, knowledgeGatewayTool]);`
`45`	`45`
`46`	`46`	`function getDisplayName(ref: string): string {`
`47`	`47`	`return (`