fix: auto allow/deny tool run requests on dynamic tool add/remove

When tools are added or removed, the socket server runs the script to
regenerate tool definitions. Now that the gateway-provider has been
incorporated as the default model provider, this logic gets stuck
waiting for user confirmation, and leads to the user getting stuck on a
loading screen. This same logic also means that if the LLM attempts to
call any other tool -- which is prone to doing without being asked to --
we run into the same problem (e.g. the second tool add hangs forever
bug).

To fix this, add a handler to the tool run that auto-approves providers
and auto-denies requests to run any other tool.

Signed-off-by: Nick Hale <[email protected]>

Author: njhale

server/app.mjs

@@ -178,7 +178,7 @@ const mount = async (location, tool, args, scriptWorkspace, socket, threadID, gp
             await runningScript.close();
             runningScript = null;
         }
-        
+
         // find the root tool and then add the new tool
         for (let block of script) {
             if (block.type === "tool") {
@@ -203,10 +203,33 @@ const mount = async (location, tool, args, scriptWorkspace, socket, threadID, gp
         socket.emit("addingTool");
 
         const currentState = JSON.parse(state.chatState);
-        
-        opts.chatState = undefined; // clear the chat state so we can get the new tool mappings
+
+        opts.chatState = undefined; // Clear the chat state so that we can get the new tool mappings
+        opts.input = 'do nothing' // Ensure the LLM doesn't try to call tools without input
         const newStateRun = await gptscript.evaluate(script, opts)
+
+        newStateRun.on(RunEventType.CallConfirm, (frame) => {
+            let response
+            if (!frame.error && frame.toolCategory === "provider") {
+                // Auto-confirm gateway provider
+                response = {
+                    id: frame.id,
+                    accept: true,
+                };
+            } else {
+                // Deny all other tool run requests
+                response = {
+                    id: frame.id,
+                    accept: false,
+                    message: 'do nothing'
+                };
+            }
+
+            gptscript.confirm(response);
+        });
+
         await newStateRun.text();
+        await newStateRun.close()
 
         const newState = JSON.parse(newStateRun.currentChatState());
         currentState.continuation.state.completion.tools = newState.continuation.state.completion.tools;
@@ -256,10 +279,33 @@ const mount = async (location, tool, args, scriptWorkspace, socket, threadID, gp
         socket.emit("removingTool");
 
         const currentState = JSON.parse(state.chatState);
-        
-        opts.chatState = undefined; // clear the chat state so we can get the new tool mappings
+
+        opts.chatState = undefined; // Clear the chat state so that we can get the new tool mappings
+        opts.input = 'do nothing' // Ensure the LLM doesn't try to call tools without input
         const newStateRun = await gptscript.evaluate(script, opts)
+
+        newStateRun.on(RunEventType.CallConfirm, (frame) => {
+            let response
+            if (!frame.error && frame.toolCategory === "provider") {
+                // Auto-confirm gateway provider
+                response = {
+                    id: frame.id,
+                    accept: true,
+                };
+            } else {
+                // Deny all other tool run requests
+                response = {
+                    id: frame.id,
+                    accept: false,
+                    message: 'do nothing'
+                };
+            }
+
+            gptscript.confirm(response);
+        });
+
         await newStateRun.text();
+        await newStateRun.close();
 
         const newState = JSON.parse(newStateRun.currentChatState());
         currentState.continuation.state.completion.tools = newState.continuation.state.completion.tools;
@@ -353,6 +399,7 @@ const initGPTScriptConfig = async (gptscript) => {
         instructions: '#!sys.echo noop'
     })
     await run.text()
+    await run.close()
 
     const configPath = gptscriptConfigPath();