feat: Add the count aggregate function #972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xl
This reverts commit 1b21ec2.
danieljbruce
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
…hub.com/danieljbruce/nodejs-datastore into count-aggregation-only-relevant-changes
danieljbruce
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
Mariatta
reviewed
Jan 10, 2023
src/aggregate.ts
Outdated
Comment on lines
15
to
17
| // ** This file is automatically generated by gapic-generator-typescript. ** | ||
| // ** https://github.com/googleapis/gapic-generator-typescript ** | ||
| // ** All changes to this file may be overwritten. ** |
Contributor
There was a problem hiding this comment.
Is the notice correct that this is autogenerated?
Contributor
Author
There was a problem hiding this comment.
It is not autogenerated. Thanks for catching this one! Changes pushed.
…hub.com/danieljbruce/nodejs-datastore into count-aggregation-only-relevant-changes
danieljbruce
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
kolea2
previously requested changes
Jan 11, 2023
danieljbruce
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
ruyadorno
approved these changes
Jan 12, 2023
Mariatta
approved these changes
Jan 12, 2023
danieljbruce
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is just like the other PR on count aggregation, but it contains only the relevant changes to make the count filter work.