Skip to content

Commit 1a94d86

Browse files
authored
Remove extra version check on GNU objdump (#554)
1 parent 0b9ab80 commit 1a94d86

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

internal/binutils/binutils.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ func isLLVMObjdump(output string) bool {
233233
// and returns a boolean indicating if the given binary is a GNU
234234
// binutils objdump binary. No version check is performed.
235235
func isBuObjdump(output string) bool {
236-
return strings.Contains(output, "GNU objdump") && strings.Contains(output, "Binutils")
236+
return strings.Contains(output, "GNU objdump")
237237
}
238238

239239
// findExe looks for an executable command on a set of paths.

internal/binutils/binutils_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -494,7 +494,7 @@ func TestObjdumpVersionChecks(t *testing.T) {
494494
},
495495
{
496496
desc: "Invalid GNU objdump version string",
497-
ver: "GNU objdump (GNU Banutils) 2.34\nCopyright (C) 2020 Free Software Foundation, Inc.",
497+
ver: "GNU nm (GNU Binutils) 2.34\nCopyright (C) 2020 Free Software Foundation, Inc.",
498498
want: false,
499499
},
500500
} {

0 commit comments

Comments
 (0)