Skip to content

Commit 4c75de3

Browse files
jnthntatumcopybara-github
authored andcommitted
Cleanup references to ast_internal:: aliases to cel::Expr and related types.
PiperOrigin-RevId: 736136737
1 parent 1e2eaa5 commit 4c75de3

File tree

83 files changed

+934
-1068
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

83 files changed

+934
-1068
lines changed

base/ast_internal/BUILD

Lines changed: 0 additions & 78 deletions
This file was deleted.

checker/BUILD

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,8 @@ cc_test(
6464
deps = [
6565
":type_check_issue",
6666
":validation_result",
67-
"//base/ast_internal:ast_impl",
6867
"//common:source",
68+
"//common/ast:ast_impl",
6969
"//internal:testing",
7070
"@com_google_absl//absl/status",
7171
"@com_google_absl//absl/status:status_matchers",
@@ -161,13 +161,13 @@ cc_test(
161161
":type_checker_builder",
162162
":type_checker_builder_factory",
163163
":validation_result",
164-
"//base/ast_internal:ast_impl",
165-
"//base/ast_internal:expr",
166164
"//checker/internal:test_ast_helpers",
167165
"//common:ast",
168166
"//common:constant",
169167
"//common:decl",
170168
"//common:type",
169+
"//common/ast:ast_impl",
170+
"//common/ast:expr",
171171
"//internal:testing",
172172
"//internal:testing_descriptor_pool",
173173
"@com_google_absl//absl/status",
@@ -203,9 +203,9 @@ cc_test(
203203
":type_checker",
204204
":type_checker_builder",
205205
":type_checker_builder_factory",
206-
"//base/ast_internal:ast_impl",
207-
"//base/ast_internal:expr",
208206
"//checker/internal:test_ast_helpers",
207+
"//common/ast:ast_impl",
208+
"//common/ast:expr",
209209
"//internal:testing",
210210
"//internal:testing_descriptor_pool",
211211
"@com_google_absl//absl/status:status_matchers",

checker/internal/BUILD

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ cc_test(
3838
srcs = ["test_ast_helpers_test.cc"],
3939
deps = [
4040
":test_ast_helpers",
41-
"//base/ast_internal:ast_impl",
4241
"//common:ast",
42+
"//common/ast:ast_impl",
4343
"//internal:testing",
4444
"@com_google_absl//absl/status",
4545
"@com_google_absl//absl/status:status_matchers",
@@ -119,8 +119,6 @@ cc_library(
119119
":namespace_generator",
120120
":type_check_env",
121121
":type_inference_context",
122-
"//base/ast_internal:ast_impl",
123-
"//base/ast_internal:expr",
124122
"//checker:checker_options",
125123
"//checker:type_check_issue",
126124
"//checker:type_checker",
@@ -137,6 +135,8 @@ cc_library(
137135
"//common:source",
138136
"//common:type",
139137
"//common:type_kind",
138+
"//common/ast:ast_impl",
139+
"//common/ast:expr",
140140
"//internal:status_macros",
141141
"//parser:macro",
142142
"@com_google_absl//absl/algorithm:container",
@@ -162,8 +162,6 @@ cc_test(
162162
":test_ast_helpers",
163163
":type_check_env",
164164
":type_checker_impl",
165-
"//base/ast_internal:ast_impl",
166-
"//base/ast_internal:expr",
167165
"//checker:checker_options",
168166
"//checker:type_check_issue",
169167
"//checker:validation_result",
@@ -172,6 +170,8 @@ cc_test(
172170
"//common:expr",
173171
"//common:source",
174172
"//common:type",
173+
"//common/ast:ast_impl",
174+
"//common/ast:expr",
175175
"//internal:status_macros",
176176
"//internal:testing",
177177
"//internal:testing_descriptor_pool",
@@ -195,12 +195,12 @@ cc_test(
195195
deps = [
196196
":test_ast_helpers",
197197
":type_checker_impl",
198-
"//base/ast_internal:ast_impl",
199-
"//base/ast_internal:expr",
200198
"//checker:type_checker",
201199
"//checker:validation_result",
202200
"//common:decl",
203201
"//common:type",
202+
"//common/ast:ast_impl",
203+
"//common/ast:expr",
204204
"//internal:testing",
205205
"//internal:testing_descriptor_pool",
206206
"@com_google_absl//absl/status",

checker/internal/test_ast_helpers_test.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818

1919
#include "absl/status/status.h"
2020
#include "absl/status/status_matchers.h"
21-
#include "base/ast_internal/ast_impl.h"
2221
#include "common/ast.h"
22+
#include "common/ast/ast_impl.h"
2323
#include "internal/testing.h"
2424

2525
namespace cel::checker_internal {

checker/internal/type_checker_builder_impl_test.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,11 @@
2323
#include "absl/status/statusor.h"
2424
#include "absl/strings/string_view.h"
2525
#include "absl/types/optional.h"
26-
#include "base/ast_internal/ast_impl.h"
27-
#include "base/ast_internal/expr.h"
2826
#include "checker/internal/test_ast_helpers.h"
2927
#include "checker/type_checker.h"
3028
#include "checker/validation_result.h"
29+
#include "common/ast/ast_impl.h"
30+
#include "common/ast/expr.h"
3131
#include "common/decl.h"
3232
#include "common/type.h"
3333
#include "common/type_introspector.h"

checker/internal/type_checker_impl.cc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,15 +32,15 @@
3232
#include "absl/time/time.h"
3333
#include "absl/types/optional.h"
3434
#include "absl/types/span.h"
35-
#include "base/ast_internal/ast_impl.h"
36-
#include "base/ast_internal/expr.h"
3735
#include "checker/checker_options.h"
3836
#include "checker/internal/namespace_generator.h"
3937
#include "checker/internal/type_check_env.h"
4038
#include "checker/internal/type_inference_context.h"
4139
#include "checker/type_check_issue.h"
4240
#include "checker/validation_result.h"
4341
#include "common/ast.h"
42+
#include "common/ast/ast_impl.h"
43+
#include "common/ast/expr.h"
4444
#include "common/ast_rewrite.h"
4545
#include "common/ast_traverse.h"
4646
#include "common/ast_visitor.h"
@@ -179,7 +179,7 @@ absl::StatusOr<AstType> FlattenType(const Type& type) {
179179
case TypeKind::kError:
180180
return AstType(ast_internal::ErrorType());
181181
case TypeKind::kNull:
182-
return AstType(ast_internal::NullValue());
182+
return AstType(nullptr);
183183
case TypeKind::kBool:
184184
return AstType(ast_internal::PrimitiveType::kBool);
185185
case TypeKind::kInt:

checker/internal/type_checker_impl_test.cc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,14 @@
2929
#include "absl/strings/match.h"
3030
#include "absl/strings/str_cat.h"
3131
#include "absl/strings/str_join.h"
32-
#include "base/ast_internal/ast_impl.h"
33-
#include "base/ast_internal/expr.h"
3432
#include "checker/checker_options.h"
3533
#include "checker/internal/test_ast_helpers.h"
3634
#include "checker/internal/type_check_env.h"
3735
#include "checker/type_check_issue.h"
3836
#include "checker/validation_result.h"
3937
#include "common/ast.h"
38+
#include "common/ast/ast_impl.h"
39+
#include "common/ast/expr.h"
4040
#include "common/decl.h"
4141
#include "common/expr.h"
4242
#include "common/source.h"
@@ -926,7 +926,7 @@ INSTANTIATE_TEST_SUITE_P(
926926
::testing::Values(
927927
AstTypeConversionTestCase{
928928
.decl_type = NullType(),
929-
.expected_type = AstType(ast_internal::NullValue()),
929+
.expected_type = AstType(nullptr),
930930
},
931931
AstTypeConversionTestCase{
932932
.decl_type = DynType(),

checker/optional_test.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,15 @@
2121

2222
#include "absl/status/status_matchers.h"
2323
#include "absl/strings/str_join.h"
24-
#include "base/ast_internal/ast_impl.h"
25-
#include "base/ast_internal/expr.h"
2624
#include "checker/checker_options.h"
2725
#include "checker/internal/test_ast_helpers.h"
2826
#include "checker/standard_library.h"
2927
#include "checker/type_check_issue.h"
3028
#include "checker/type_checker.h"
3129
#include "checker/type_checker_builder.h"
3230
#include "checker/type_checker_builder_factory.h"
31+
#include "common/ast/ast_impl.h"
32+
#include "common/ast/expr.h"
3333
#include "internal/testing.h"
3434
#include "internal/testing_descriptor_pool.h"
3535

checker/standard_library_test.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,15 @@
2020

2121
#include "absl/status/status.h"
2222
#include "absl/status/status_matchers.h"
23-
#include "base/ast_internal/ast_impl.h"
24-
#include "base/ast_internal/expr.h"
2523
#include "checker/checker_options.h"
2624
#include "checker/internal/test_ast_helpers.h"
2725
#include "checker/type_checker.h"
2826
#include "checker/type_checker_builder.h"
2927
#include "checker/type_checker_builder_factory.h"
3028
#include "checker/validation_result.h"
3129
#include "common/ast.h"
30+
#include "common/ast/ast_impl.h"
31+
#include "common/ast/expr.h"
3232
#include "common/constant.h"
3333
#include "common/decl.h"
3434
#include "common/type.h"

checker/validation_result_test.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@
1919

2020
#include "absl/status/status.h"
2121
#include "absl/status/status_matchers.h"
22-
#include "base/ast_internal/ast_impl.h"
2322
#include "checker/type_check_issue.h"
23+
#include "common/ast/ast_impl.h"
2424
#include "common/source.h"
2525
#include "internal/testing.h"
2626

0 commit comments

Comments
 (0)