Skip to content

Commit 424e4d8

Browse files
jckingcopybara-github
authored andcommitted
Remove usages of native JSON and Any representations
PiperOrigin-RevId: 715013876
1 parent 38230a1 commit 424e4d8

File tree

100 files changed

+2540
-1404
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

100 files changed

+2540
-1404
lines changed

common/BUILD

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -410,12 +410,19 @@ cc_library(
410410
":type",
411411
":value",
412412
":value_kind",
413+
"//internal:equals_text_proto",
414+
"//internal:parse_text_proto",
413415
"//internal:testing",
416+
"//internal:testing_descriptor_pool",
417+
"//internal:testing_message_factory",
418+
"@com_google_absl//absl/log:die_if_null",
414419
"@com_google_absl//absl/status",
415420
"@com_google_absl//absl/status:status_matchers",
416421
"@com_google_absl//absl/status:statusor",
422+
"@com_google_absl//absl/strings:string_view",
417423
"@com_google_absl//absl/time",
418424
"@com_google_absl//absl/types:optional",
425+
"@com_google_protobuf//:protobuf",
419426
],
420427
)
421428

@@ -644,6 +651,7 @@ cc_library(
644651
"//eval/public:message_wrapper",
645652
"//eval/public/containers:field_backed_list_impl",
646653
"//eval/public/containers:field_backed_map_impl",
654+
"//eval/public/structs:cel_proto_wrap_util",
647655
"//eval/public/structs:legacy_type_adapter",
648656
"//eval/public/structs:legacy_type_info_apis",
649657
"//eval/public/structs:proto_message_type_adapter",
@@ -693,7 +701,6 @@ cc_test(
693701
"values/*_test.cc",
694702
]) + [
695703
"type_reflector_test.cc",
696-
"value_factory_test.cc",
697704
"value_test.cc",
698705
],
699706
deps = [
@@ -708,6 +715,7 @@ cc_test(
708715
":value",
709716
":value_kind",
710717
":value_testing",
718+
"//internal:equals_text_proto",
711719
"//internal:message_type_name",
712720
"//internal:parse_text_proto",
713721
"//internal:status_macros",

common/json.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
#include "absl/strings/cord.h"
3030
#include "absl/strings/string_view.h"
3131
#include "absl/types/variant.h"
32-
#include "common/any.h"
3332
#include "internal/copy_on_write.h"
3433
#include "google/protobuf/descriptor.h"
3534
#include "google/protobuf/message.h"
@@ -487,9 +486,6 @@ class AnyToJsonConverter {
487486
public:
488487
virtual ~AnyToJsonConverter() = default;
489488

490-
virtual absl::StatusOr<Json> ConvertToJson(absl::string_view type_url,
491-
const absl::Cord& value) = 0;
492-
493489
virtual absl::Nullable<const google::protobuf::DescriptorPool*> descriptor_pool()
494490
const {
495491
return nullptr;

0 commit comments

Comments
 (0)