Skip to content

Commit c53c261

Browse files
committed
chore: Fix spelling
ci: Fix test to honor existing repository code Add from __future__ import annotations Required by: Check for import pattern in certain changed Python files Fix links: - BigQuery first-party tools - bidirectional streaming - 2e77804 Fix spelling: - , the - ; otherwise, - a missing input - a user - a - accordingly - across - actual - add - all the - and references - answer - appended - arg - args - associated - async - at - attractions - auth - between - bigquery - cannot - case-insensitive - case-sensitive - comment - connection - constructor - contributor - convert - corresponding - credential - criteria - current - custom - data - deprecated - descriptions - different - directory - doesn't - enforce - evaluation - example - exception - exchange - execution - extension - externally - extract - fall back - format - function - future - generate - github - global - guidance - handle - id - identify - implements - include - increased - initial - initialize - inline - into - invocation - jira - langchain - list - litellm - manage - maximum - metrics - model's template - neither-nor - nonexistent - number - output - own - participate - permanent - persisting - preexisting - prepopulated - properties - protected - pydantic - received - relevant - repetitive - response - responses - results - returns - score - search - secret - service - single - spec - successfully - surface - temporary - that the - the module - the - there are - transferred - unstructured - weather Signed-off-by: Josh Soref <[email protected]>
1 parent 9478a31 commit c53c261

File tree

124 files changed

+268
-273
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

124 files changed

+268
-273
lines changed

.github/workflows/check-file-contents.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ jobs:
8989
- name: Check for import from cli package in certain changed Python files
9090
run: |
9191
git fetch origin ${{ github.base_ref }}
92-
CHANGED_FILES=$(git diff --diff-filter=ACMR --name-only origin/${{ github.base_ref }}...HEAD | grep -E '\.py$' | grep -v -E 'cli/.*|tests/.*|contributing/samples/' || true)
92+
CHANGED_FILES=$(git diff --diff-filter=ACMR --name-only origin/${{ github.base_ref }}...HEAD | grep -E '\.py$' | grep -v -E 'cli/.*|src/google/adk/tools/apihub_tool/apihub_toolset.py|tests/.*|contributing/samples/' || true)
9393
if [ -n "$CHANGED_FILES" ]; then
9494
echo "Changed Python files to check:"
9595
echo "$CHANGED_FILES"

AGENTS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ $ ./autoformat.sh
4646

4747
### In ADK source
4848

49-
Below styles applies to the ADK source code (under `src/` folder of the Github.
49+
Below styles applies to the ADK source code (under `src/` folder of the GitHub.
5050
repo).
5151

5252
#### Use relative imports

CHANGELOG.md

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
### Improvements
2323

24-
* Add Github workflow config for the ADK Answering agent ([8dc0c94](https://github.com/google/adk-python/commit/8dc0c949afb9024738ff7ac1b2c19282175c3200))
24+
* Add GitHub workflow config for the ADK Answering agent ([8dc0c94](https://github.com/google/adk-python/commit/8dc0c949afb9024738ff7ac1b2c19282175c3200))
2525
* Import AGENT_CARD_WELL_KNOWN_PATH from adk instead of from a2a directly ([37dae9b](https://github.com/google/adk-python/commit/37dae9b631db5060770b66fce0e25cf0ffb56948))
2626
* Make `LlmRequest.LiveConnectConfig` field default to a factory ([74589a1](https://github.com/google/adk-python/commit/74589a1db7df65e319d1ad2f0676ee0cf5d6ec1d))
2727
* Update the prompt to make the ADK Answering Agent more objective ([2833030](https://github.com/google/adk-python/commit/283303032a174d51b8d72f14df83c794d66cb605))
@@ -80,14 +80,13 @@
8080
### Features
8181

8282
* [Core]Add agent card builder ([18f5bea](https://github.com/google/adk-python/commit/18f5bea411b3b76474ff31bfb2f62742825b45e5))
83-
* [Core]Add an to_a2a util to convert adk agent to A2A ASGI application ([a77d689](https://github.com/google/adk-python/commit/a77d68964a1c6b7659d6117d57fa59e43399e0c2))
83+
* [Core]Add a to_a2a util to convert adk agent to A2A ASGI application ([a77d689](https://github.com/google/adk-python/commit/a77d68964a1c6b7659d6117d57fa59e43399e0c2))
8484
* [Core]Add camel case converter for agents ([0e173d7](https://github.com/google/adk-python/commit/0e173d736334f8c6c171b3144ac6ee5b7125c846))
8585
* [Evals]Use LocalEvalService to run all evals in cli and web ([d1f182e](https://github.com/google/adk-python/commit/d1f182e8e68c4a5a4141592f3f6d2ceeada78887))
8686
* [Evals]Enable FinalResponseMatchV2 metric as an experiment ([36e45cd](https://github.com/google/adk-python/commit/36e45cdab3bbfb653eee3f9ed875b59bcd525ea1))
8787
* [Models]Add support for `model-optimizer-*` family of models in vertex ([ffe2bdb](https://github.com/google/adk-python/commit/ffe2bdbe4c2ea86cc7924eb36e8e3bb5528c0016))
8888
* [Services]Added a sample for History Management ([67284fc](https://github.com/google/adk-python/commit/67284fc46667b8c2946762bc9234a8453d48a43c))
89-
* [Services]Support passing fully qualified agent engine resource name when constructing session service and memory service ([2e77804](https://github.com/google/adk-python/commit/2e778049d0a675e458f4e
90-
35fe4104ca1298dbfcf))
89+
* [Services]Support passing fully qualified agent engine resource name when constructing session service and memory service ([2e77804](https://github.com/google/adk-python/commit/2e778049d0a675e458f4e35fe4104ca1298dbfcf))
9190
* [Tools]Add ComputerUseToolset ([083dcb4](https://github.com/google/adk-python/commit/083dcb44650eb0e6b70219ede731f2fa78ea7d28))
9291
* [Tools]Allow toolset to process llm_request before tools returned by it ([3643b4a](https://github.com/google/adk-python/commit/3643b4ae196fd9e38e52d5dc9d1cd43ea0733d36))
9392
* [Tools]Support input/output schema by fully-qualified code reference ([dfee06a](https://github.com/google/adk-python/commit/dfee06ac067ea909251d6fb016f8331065d430e9))
@@ -200,7 +199,7 @@
200199

201200
### Documentation
202201

203-
* Update the a2a exmaple link in README.md [d0fdfb8](https://github.com/google/adk-python/commit/d0fdfb8c8e2e32801999c81de8d8ed0be3f88e76)
202+
* Update the a2a example link in README.md [d0fdfb8](https://github.com/google/adk-python/commit/d0fdfb8c8e2e32801999c81de8d8ed0be3f88e76)
204203
* Adds AGENTS.md to provide relevant project context for the Gemini CLI [37108be](https://github.com/google/adk-python/commit/37108be8557e011f321de76683835448213f8515)
205204
* Update CONTRIBUTING.md [ffa9b36](https://github.com/google/adk-python/commit/ffa9b361db615ae365ba62c09a8f4226fb761551)
206205
* Add adk project overview and architecture [28d0ea8](https://github.com/google/adk-python/commit/28d0ea876f2f8de952f1eccbc788e98e39f50cf5)
@@ -395,7 +394,7 @@
395394
* Fix typos in README for sample bigquery_agent and oauth_calendar_agent ([9bdd813](https://github.com/google/adk-python/commit/9bdd813be15935af5c5d2a6982a2391a640cab23))
396395
* Make tool_call one span for telemetry and renamed to execute_tool ([999a7fe](https://github.com/google/adk-python/commit/999a7fe69d511b1401b295d23ab3c2f40bccdc6f))
397396
* Use media type in chat window. Remove isArtifactImage and isArtifactAudio reference ([1452dac](https://github.com/google/adk-python/commit/1452dacfeb6b9970284e1ddeee6c4f3cb56781f8))
398-
* Set output_schema correctly for LiteLllm ([6157db7](https://github.com/google/adk-python/commit/6157db77f2fba4a44d075b51c83bff844027a147))
397+
* Set output_schema correctly for LiteLlm ([6157db7](https://github.com/google/adk-python/commit/6157db77f2fba4a44d075b51c83bff844027a147))
399398
* Update pending event dialog style ([1db601c](https://github.com/google/adk-python/commit/1db601c4bd90467b97a2f26fe9d90d665eb3c740))
400399
* Remove the gap between event holder and image ([63822c3](https://github.com/google/adk-python/commit/63822c3fa8b0bdce2527bd0d909c038e2b66dd98))
401400

@@ -423,7 +422,7 @@
423422
## 1.1.1
424423

425424
### Features
426-
* Add BigQuery first-party tools. See [here](https://github.com/google/adk-python/commit/d6c6bb4b2489a8b7a4713e4747c30d6df0c07961) for more details.
425+
* Add [BigQuery first-party tools](https://github.com/google/adk-python/commit/d6c6bb4b2489a8b7a4713e4747c30d6df0c07961) for more details.
427426

428427

429428
## 1.1.0
@@ -559,7 +558,7 @@
559558
* Fix google search reading undefined for `renderedContent`.
560559

561560
### Miscellaneous Chores
562-
* Docstring improvements, typo fixings, github action to enfore code styles on formatting and imports, etc.
561+
* Docstring improvements, typo fixings, github action to enforce code styles on formatting and imports, etc.
563562

564563
## 0.3.0
565564

@@ -598,7 +597,7 @@
598597

599598
### ⚠ BREAKING CHANGES
600599

601-
* Fix typo in method name in `Event`: has_trailing_code_exeuction_result --> has_trailing_code_execution_result.
600+
* Fix typo in method name in `Event`: has_trailing_code_execution_result --> has_trailing_code_execution_result.
602601

603602
### Features
604603

@@ -628,7 +627,7 @@
628627

629628
### Miscellaneous Chores
630629

631-
* Adds unit tests in Github action.
630+
* Adds unit tests in GitHub action.
632631
* Improves test coverage.
633632
* Various typo fixes.
634633

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ This project follows
5050
## Requirement for PRs
5151

5252
- Each PR should only have one commit. Please squash it if there are multiple PRs.
53-
- All PRs, other than small documentation or typo fixes, should have a Issue assoicated. If not, please create one.
53+
- All PRs, other than small documentation or typo fixes, should have a Issue associated. If not, please create one.
5454
- Small, focused PRs. Keep changes minimal—one concern per PR.
5555
- For bug fixes or features, please provide logs or screenshot after the fix is applied to help reviewers better understand the fix.
5656
- Please include a `testing plan` section in your PR to talk about how you will test. This will save time for PR review. See `Testing Requirements` section for more details.

contributing/samples/a2a_auth/remote_a2a/bigquery_agent/agent.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
Use the provided tools to conduct various operations on users' data in Google BigQuery.
4747
4848
Scenario 1:
49-
The user wants to query their biguqery datasets
49+
The user wants to query their bigquery datasets
5050
Use bigquery_datasets_list to query user's datasets
5151
5252
Scenario 2:

contributing/samples/a2a_human_in_loop/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ Agent: ✅ Great news! Your reimbursement has been approved by the manager. Proc
9999
The human-in-the-loop process follows this pattern:
100100

101101
1. **Initial Call**: Root agent delegates approval request to remote approval agent for amounts >$100
102-
2. **Pending Response**: Remote approval agent returns immediate response with `status: "pending"` and ticket ID and serface the approval request to root agent
102+
2. **Pending Response**: Remote approval agent returns immediate response with `status: "pending"` and ticket ID and surface the approval request to root agent
103103
3. **Agent Acknowledgment**: Root agent informs user about pending approval status
104104
4. **Human Interaction**: Human manager interacts with root agent to review and approve/reject the request
105105
5. **Updated Response**: Root agent receives updated tool response with approval decision and send it to remote agent

contributing/samples/adk_answering_agent/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ Or `python -m adk_answering_agent.answer_discussions --recent 10` to answer the
5050

5151
## GitHub Workflow Mode
5252

53-
The `main.py` is reserved for the Github Workflow. The detailed setup for the automatic workflow is TBD.
53+
The `main.py` is reserved for the GitHub Workflow. The detailed setup for the automatic workflow is TBD.
5454

5555
---
5656

contributing/samples/adk_answering_agent/agent.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,13 +47,13 @@
4747
1. Use the `get_discussion_and_comments` tool to get the details of the discussion including the comments.
4848
2. Focus on the latest comment but reference all comments if needed to understand the context.
4949
* If there is no comment at all, just focus on the discussion title and body.
50-
3. If all the following conditions are met, try to add a comment to the discussion, otherwise, do not respond:
50+
3. If all the following conditions are met, try to add a comment to the discussion; otherwise, do not respond:
5151
* The discussion is not closed.
5252
* The latest comment is not from you or other agents (marked as "Response from XXX Agent").
5353
* The latest comment is asking a question or requesting information.
5454
4. Use the `VertexAiSearchTool` to find relevant information before answering.
5555
5. If you can find relevant information, use the `add_comment_to_discussion` tool to add a comment to the discussion.
56-
6. If you post a commment and the discussion does not have a label named {BOT_RESPONSE_LABEL},
56+
6. If you post a comment and the discussion does not have a label named {BOT_RESPONSE_LABEL},
5757
add the label {BOT_RESPONSE_LABEL} to the discussion using the `add_label_to_discussion` tool.
5858
5959
@@ -63,7 +63,7 @@
6363
information that is not in the document store. Do not invent citations which are not in the document store.
6464
* **Be Objective**: your answer should be based on the facts you found in the document store, do not be misled by user's assumptions or user's understanding of ADK.
6565
* If you can't find the answer or information in the document store, **do not** respond.
66-
* Inlclude a short summary of your response in the comment as a TLDR, e.g. "**TLDR**: <your summary>".
66+
* Include a short summary of your response in the comment as a TLDR, e.g. "**TLDR**: <your summary>".
6767
* Have a divider line between the TLDR and your detail response.
6868
* Do not respond to any other discussion except the one specified by the user.
6969
* Please include your justification for your decision in your output

contributing/samples/adk_answering_agent/answer_discussions.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ async def list_most_recent_discussions(count: int = 1) -> list[int] | None:
8787
def process_arguments():
8888
"""Parses command-line arguments."""
8989
parser = argparse.ArgumentParser(
90-
description="A script that answer questions for Github discussions.",
90+
description="A script that answer questions for GitHub discussions.",
9191
epilog=(
9292
"Example usage: \n"
9393
"\tpython -m adk_answering_agent.answer_discussions --recent 10\n"

contributing/samples/adk_answering_agent/upload_docs_to_vertex_ai_search.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ def upload_directory_to_gcs(
117117
)
118118
return False
119119

120-
print(f"Sucessfully uploaded {file_count} files to GCS.")
120+
print(f"Successfully uploaded {file_count} files to GCS.")
121121
return True
122122

123123

@@ -135,7 +135,7 @@ def import_from_gcs_to_vertex_ai(
135135
# parent has the format of
136136
# "projects/{project_number}/locations/{location}/collections/{collection}/dataStores/{datastore_id}/branches/default_branch"
137137
parent=full_datastore_id + "/branches/default_branch",
138-
# Specify the GCS source and use "content" for unstructed data.
138+
# Specify the GCS source and use "content" for unstructured data.
139139
gcs_source=discoveryengine.GcsSource(
140140
input_uris=[gcs_uri], data_schema="content"
141141
),

0 commit comments

Comments
 (0)