feat(cli): rm socks5 proxy protocol, reuse https-proxy-agent for http & https protocol

Co-authored-by: Dcatfly <[email protected]>

Author: warjiang

package-lock.json

@@ -38,14 +38,12 @@
     "glob": "^10.4.5",
     "google-auth-library": "^9.11.0",
     "html-to-text": "^9.0.5",
-    "http-proxy-agent": "^7.0.2",
     "https-proxy-agent": "^7.0.6",
     "ignore": "^7.0.0",
     "micromatch": "^4.0.8",
     "open": "^10.1.2",
     "shell-quote": "^1.8.2",
     "simple-git": "^3.28.0",
-    "socks-proxy-agent": "^8.0.5",
     "strip-ansi": "^7.1.0",
     "undici": "^7.10.0",
     "ws": "^8.18.0"

packages/core/package.json

@@ -6,8 +6,6 @@
 
 import { Buffer } from 'buffer';
 import * as https from 'https';
-import { SocksProxyAgent } from 'socks-proxy-agent';
-import { HttpProxyAgent } from 'http-proxy-agent';
 import { HttpsProxyAgent } from 'https-proxy-agent';
 
 import {
@@ -402,12 +400,12 @@ export class ClearcutLogger {
   getProxyAgent() {
     const proxyUrl = this.config?.getProxy();
     if (!proxyUrl) return undefined;
-    if (proxyUrl.startsWith('socks')) {
-      return new SocksProxyAgent(proxyUrl);
-    } else if (proxyUrl.startsWith('https')) {
+    // undici which is widely used in the repo can only support http & https proxy protocol,
+    // https://github.com/nodejs/undici/issues/2224
+    // as @Dcatfly metioned, `HttpsProxyAgent` can support https & http proxy protocol at the same time, 
+    // so only use `https-proxy-agent` dependency now.
+    if (proxyUrl.startsWith('http')) {
       return new HttpsProxyAgent(proxyUrl);
-    } else if (proxyUrl.startsWith('http')) {
-      return new HttpProxyAgent(proxyUrl);
     } else {
       throw new Error('Unsupported proxy type');
     }