Implement list cards #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettdh
force-pushed
the
components/list-cards
branch
from
b8a97ae to
acd1646
Compare
brettdh
force-pushed
the
components/person-list
branch
2 times, most recently
from
9245917 to
70b8dca
Compare
brettdh
force-pushed
the
components/list-cards
branch
from
acd1646 to
157d289
Compare
CaleCrawford
approved these changes
Mar 10, 2018
Contributor
CaleCrawford
left a comment
CaleCrawford
left a comment
There was a problem hiding this comment.
LGTM. Sorry it took me so long to get around to this.
src/components/PlayableListCard.js
Outdated
Contributor
There was a problem hiding this comment.
Very small thing, do we want to account for the singular? (1 Minute). Seems pretty unlikely but thought I'd make note anyway.
Contributor
Author
There was a problem hiding this comment.
For context here: this is resolved in a later PR (which I know you mentioned there 🙂)
Arbitrary content, style overrides.
ListCard has passthrough props.
brettdh
force-pushed
the
components/list-cards
branch
from
157d289 to
c9cba6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #49.
Motivation and Context
See #47.
Screenshots (if appropriate):