support constraint

Author: Fs02

add_error_test.go

@@ -1,6 +1,7 @@
 package changeset
 
 import (
+	"errors"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -24,3 +25,12 @@ func TestAddError(t *testing.T) {
 	assert.Equal(t, 2, len(ch.Errors()))
 	assert.Equal(t, "field2 is not valid", ch.Errors()[1].Error())
 }
+
+func TestError_Unwrap(t *testing.T) {
+	var (
+		wrappedError = errors.New("error")
+		err          = Error{Err: wrappedError}
+	)
+
+	assert.Equal(t, wrappedError, err.Unwrap())
+}

changeset.go

@@ -103,6 +103,11 @@ func (c *Changeset) Apply(doc *rel.Document, mut *rel.Mutation) {
 	if doc.Flag(rel.HasUpdatedAt) {
 		c.set(doc, mut, "updated_at", now)
 	}
+
+	// add error func
+	if len(c.constraints) > 0 {
+		mut.ErrorFunc = c.constraints.GetError
+	}
 }
 
 func (c *Changeset) set(doc *rel.Document, mut *rel.Mutation, field string, value interface{}) {

changeset_test.go

@@ -139,9 +139,6 @@ func TestChangesetApply(t *testing.T) {
 		)
 	)
 
-	userMutation.SetAssoc("transactions", transaction1Mutation, transaction2Mutation)
-	userMutation.SetAssoc("address", addressMutation)
-
 	ch := Cast(user, input, []string{"name", "age"})
 	CastAssoc(ch, "transactions", func(data interface{}, input params.Params) *Changeset {
 		ch := Cast(data, input, []string{"item", "status"})
@@ -152,6 +149,9 @@ func TestChangesetApply(t *testing.T) {
 		return ch
 	})
 
+	userMutation.SetAssoc("transactions", transaction1Mutation, transaction2Mutation)
+	userMutation.SetAssoc("address", addressMutation)
+
 	assert.Nil(t, ch.Error())
 	assert.Equal(t, userMutation, rel.Apply(doc, ch))
 	assert.Equal(t, User{
@@ -170,3 +170,35 @@ func TestChangesetApply(t *testing.T) {
 		},
 	}, user)
 }
+
+func TestChangesetApply_constraint(t *testing.T) {
+	var (
+		user  User
+		now   = time.Now().Truncate(time.Second)
+		doc   = rel.NewDocument(&user)
+		input = params.Map{
+			"name": "Luffy",
+			"age":  20,
+		}
+		userMutation = rel.Apply(rel.NewDocument(&User{}),
+			rel.Set("name", "Luffy"),
+			rel.Set("age", 20),
+			rel.Set("created_at", now),
+			rel.Set("updated_at", now),
+		)
+	)
+
+	ch := Cast(user, input, []string{"name", "age"})
+	UniqueConstraint(ch, "name")
+	mut := rel.Apply(doc, ch)
+
+	assert.Nil(t, ch.Error())
+	assert.Equal(t, userMutation.Mutates, mut.Mutates)
+	assert.NotNil(t, mut.ErrorFunc)
+	assert.Equal(t, User{
+		Name:      "Luffy",
+		Age:       20,
+		CreatedAt: now,
+		UpdatedAt: now,
+	}, user)
+}

constraint.go

@@ -24,14 +24,19 @@ type Constraints []Constraint
 // If the original error is constraint error, and it's defined in the constraint list, then it'll be updated with constraint's message.
 // If the original error is constraint error but not defined in the constraint list, it'll be converted to unexpected error.
 // else it'll not modify the error.
-func (constraints Constraints) GetError(err rel.ConstraintError) error {
+func (constraints Constraints) GetError(err error) error {
+	cerr, ok := err.(rel.ConstraintError)
+	if !ok {
+		return err
+	}
+
 	for _, c := range constraints {
-		if c.Type == err.Type {
-			if c.Exact && c.Name != err.Key {
+		if c.Type == cerr.Type {
+			if c.Exact && c.Name != cerr.Key {
 				continue
 			}
 
-			if !c.Exact && !strings.Contains(err.Key, c.Name) {
+			if !c.Exact && !strings.Contains(cerr.Key, c.Name) {
 				continue
 			}
 

constraint_test.go

@@ -15,7 +15,7 @@ func TestConstraint_GetError(t *testing.T) {
 
 	tests := []struct {
 		name     string
-		err      rel.ConstraintError
+		err      error
 		expected error
 	}{
 		{
@@ -43,6 +43,11 @@ func TestConstraint_GetError(t *testing.T) {
 			err:      rel.ConstraintError{Key: "other_id_ibfk1", Type: rel.ForeignKeyConstraint},
 			expected: rel.ConstraintError{Key: "other_id_ibfk1", Type: rel.ForeignKeyConstraint},
 		},
+		{
+			name:     "other error",
+			err:      rel.NotFoundError{},
+			expected: rel.NotFoundError{},
+		},
 	}
 
 	for _, tt := range tests {

go.mod

@@ -4,7 +4,7 @@ go 1.13
 
 require (
 	github.com/Fs02/grimoire v1.5.0
-	github.com/Fs02/rel v0.4.0
+	github.com/Fs02/rel v0.4.1-0.20200613111837-557349925ce2
 	github.com/azer/snakecase v0.0.0-20161028114325-c818dddafb5c
 	github.com/stretchr/testify v1.5.1
 	github.com/tidwall/gjson v1.6.0

go.sum

@@ -4,6 +4,8 @@ github.com/Fs02/grimoire v1.5.0 h1:BnFaZ0FHzQpnzLlIGe8iOqgGeRLps33TeVGSsCFUAio=
 github.com/Fs02/grimoire v1.5.0/go.mod h1:Zym+jMh+rHBZxP342yxGJxQImPV0Nc6meEt5+qQY3N8=
 github.com/Fs02/rel v0.4.0 h1:iop6aPDb2gfTIxYIbFq1sTEMJzSjlryb+mfFkSqgeig=
 github.com/Fs02/rel v0.4.0/go.mod h1:MeJHkZO46QVfjagPSnYX/noguNDOqNK2LLGse77asxw=
+github.com/Fs02/rel v0.4.1-0.20200613111837-557349925ce2 h1:zTJnXFb2L571q6RpZcQco/kGnwFaYcrPKhYA2WwAkto=
+github.com/Fs02/rel v0.4.1-0.20200613111837-557349925ce2/go.mod h1:MeJHkZO46QVfjagPSnYX/noguNDOqNK2LLGse77asxw=
 github.com/azer/snakecase v0.0.0-20161028114325-c818dddafb5c h1:7zL0ljVI6ads5EFvx+Oq+uompnFBMJqtbuHvyobbJ1Q=
 github.com/azer/snakecase v0.0.0-20161028114325-c818dddafb5c/go.mod h1:iApMeoHF0YlMPzCwqH/d59E3w2s8SeO4rGK+iGClS8Y=
 github.com/davecgh/go-spew v1.1.0 h1:ZDRjVQ15GmhC3fiQ8ni8+OwkZQO4DARzQgrnXU1Liz8=